Skip to content

duplicate framework assembly references #297

Description

@ctaggart

I've had to lock our use of paket to 0.8.5. The breaking issue is that FSharp.Data.SqlClient isn't showing up as a reference in one of our projects after a paket update with 0.9.7. I haven't been able to isolate the problem in a test solution yet.

However, I created a project and added a handful of commits to it, trying to reproduce the issues I'm seeing. This is the first one that may be related. I'm seeing more duplicate references with 0.9.7:

https://github.com/ctaggart/Paket09x/commits

image

0.8.5 just has Microsoft.SqlServer.Types listed twice:

image

Activity

  1. forki commented on Oct 24, 2014

    @forki
    Member

    Thanks I will look into this in Monday
    On Oct 24, 2014 8:01 PM, "Cameron Taggart" notifications@github.com wrote:

    I've had to lock our use of paket to 0.8.5. The breaking issue is that
    FSharp.Data.SqlClient isn't showing up as a reference in one of our
    projects after a paket update with 0.9.7. I haven't been able to isolate
    the problem in a test solution yet.

    However, I created a project and added a handful of commits to it, trying
    to reproduce the issues I'm seeing. This is the first one that may be
    related. I'm seeing more duplicate references with 0.9.7:

    https://github.com/ctaggart/Paket09x/commits

    [image: image]
    https://cloud.githubusercontent.com/assets/80104/4773896/963b7156-5ba7-11e4-8179-e91e78e5a317.png

    0.8.5 just has Microsoft.SqlServer.Types listed twice:

    [image: image]
    https://cloud.githubusercontent.com/assets/80104/4773905/a8f55a82-5ba7-11e4-9f58-be63030ca544.png

    —
    Reply to this email directly or view it on GitHub
    #297.

  2. ctaggart commented on Oct 24, 2014

    @ctaggart
    ContributorAuthor

    It looks like it may be an issue with the nuspec for the FSharp.Data.SqlClient project. I submitted a pull request. fsprojects/FSharp.Data.SqlClient#75 When I get the new version, I'll try again.

  3. ctaggart commented on Oct 24, 2014

    @ctaggart
    ContributorAuthor

    The SqlClient bug solved the duplicate Microsoft.SqlServer.Types, but not any of the frameworksAssemblies duplicate references. Looks like a problem with #146.

    I simplified the example solution to have these two dependencies.

    source https://nuget.org/api/v2
    
    nuget Microsoft.AspNet.WebApi.Client
    nuget Microsoft.Owin.Testing
    

    Their nuspec files have:

        <frameworkAssemblies>
          <frameworkAssembly assemblyName="System.Net.Http" targetFramework=".NETFramework4.5" />
        </frameworkAssemblies>
    

    Which leads to this in 0.8.5:
    image

    and this is 0.9.7:
    image

  4. changed the title [-]duplicate references[/-] [+]duplicate framework assembly references[/+] on Oct 24, 2014
  5. forki commented on Oct 27, 2014

    @forki
    Member

    I think we need to check if it already exists

  6. reopened this on Oct 28, 2014
  7. forki commented on Oct 28, 2014

    @forki
    Member

    First try was wrong

  8. reopened this on Oct 28, 2014
  9. forki commented on Oct 28, 2014

    @forki
    Member

    could you please test 0.11.0-alpha001?

  10. ctaggart commented on Oct 28, 2014

    @ctaggart
    ContributorAuthor

    Tested this an it appears to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions