Repository navigation
Duplicates appear in generated scripts. #2716
Description
Description
Duplicate #r lines appear in generated script files. Is this necessary? Can it cause problems?
Repro steps
Use the Entity Framework nuget package as a test case.
Expected behavior
I would expect to see the following in the generated script file:
#r "System.ComponentModel.DataAnnotations"
#r "../../../packages/EntityFramework/lib/net45/EntityFramework.dll"
#r "../../../packages/EntityFramework/lib/net45/EntityFramework.SqlServer.dll"
Actual behavior
Paket generates a file as follows:
#r "System.ComponentModel.DataAnnotations"
#r "System.ComponentModel.DataAnnotations"
#r "../../../packages/EntityFramework/lib/net45/EntityFramework.dll"
#r "../../../packages/EntityFramework/lib/net45/EntityFramework.SqlServer.dll"
Known workarounds
Create your own references file.
Activity
forki commentedon Sep 4, 2017
isaacabraham commentedon Sep 4, 2017
Maybe just a
distinctrather than a hashset - need to maintain ordering I would imagine?forki commentedon Sep 4, 2017
distinct is using a hashset ;-)
forki commentedon Sep 4, 2017
https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/FSharp.Core/seq.fs#L1084-L1089
isaacabraham commentedon Sep 4, 2017
Yes but it maintains order? Does Hashset?
forki commentedon Sep 4, 2017
look at the code. it just checks if the the thing is already in the set. It doesn't retrieve things from the set. So yes order is maintained
isaacabraham commentedon Sep 4, 2017
ok sorry.
matthid commentedon Sep 4, 2017
Yes use
distinct@forki is only trying to confuse you ;)matthid commentedon Sep 4, 2017
It shouldn't actually cause any harm so up-for-grabs
forki commentedon Sep 4, 2017
isaacabraham commentedon Sep 4, 2017
Very kind of you When I can get the solution to open on my PC maybe I'll do it otherwise yes up for grabs please
Merge pull request #2767 from t-krag/master