Pinned dependency causes conflict #1520

Activity

1. inosik commented on Mar 16, 2016

   

   inosik

   on Mar 16, 2016

   Contributor

   More actions

   According to nuget.org, Microsoft.ApplicationInsights.WindowsServer v1.2.3 requires = 1.2.3 of Microsoft.ApplicationInsights and >= 1.2.3 for it's other dependencies. That's why Paket tries to get v2.0.0 of Microsoft.ApplicationInsights.*.

   You could use strategy: min, to emulate NuGet's behavior of downloading the oldest compatible version. This should get v1.2.3 of every package, which Microsoft.ApplicationInsights.WindowsServer depends on.
2. forki commented on Mar 16, 2016

   

   forki

   on Mar 16, 2016

   Member

   More actions

   I believe strategy:min vs max should not result in conflict vs. non-conflict since it only changes order. I'll take a deeper look
3. forki

   added

   bug

   on Mar 16, 2016
4. forki commented on Mar 16, 2016

   

   forki

   on Mar 16, 2016

   Member

   More actions

   I'm pretty sure this is a bug, but not sure where exactly yet
5. forki commented on Mar 16, 2016

   

   forki

   on Mar 16, 2016

   Member

   More actions

   @mrinaldi

   It has something to do with this optimization:

   match !state with
   | Resolution.Conflict(_,_,stillOpen,_,_) 
       when stillOpen |> Set.exists (fun r -> r = currentRequirement || r.Graph |> List.contains currentRequirement) |> not ->
           forceBreak := true
   | _ -> ()
   

   If I comment this block out then it finds a resolution.
6. forki

   added 2 commits that reference this issue on Mar 16, 2016

   Force resolver to look into deeper levels - fixes #1520

   This issue will close once commit 355708f is merged into the 'master' branch.

   355708f

   Force resolver to look into deeper levels - fixes #1520

   ...

   This issue will close once commit 28d9b82 is merged into the 'master' branch.

   28d9b82
7. forki commented on Mar 16, 2016

   

   forki

   on Mar 16, 2016

   Member

   More actions

   I think 28d9b82#diff-781e85b03afcc7c6cedfbd46e3d3b607R430 solves it.

   👍React with 👍1Reacted by Marcio Rinaldi
8. forki

   closed this as completedin 28d9b82on Mar 16, 2016
9. forki commented on Mar 16, 2016

   

   forki

   on Mar 16, 2016

   Member

   More actions

   please give it another try

   👍React with 👍1Reacted by Isaac Abraham
10. forki

    reopened this on Mar 16, 2016
11. forki

    closed this as completedon Mar 16, 2016
12. isaacabraham commented on Mar 16, 2016

    

    isaacabraham

    on Mar 16, 2016

    ContributorAuthor

    More actions

    Yeah works now! Interestingly I still get up to 2.x for some of the transitive dependencies - is there a way to stop this aside from adding those manually into the .dependencies file?
13. forki commented on Mar 16, 2016

    

    forki

    on Mar 16, 2016

    Member

    More actions

    Yes now you can try to change the strategy to min.
    On Mar 16, 2016 11:20 AM, "Isaac Abraham" notifications@github.com wrote:

    Yeah works now! Interestingly I still get up to 2.x for some of the
    transitive dependencies - is there a way to stop this aside from adding
    those manually into the .dependencies file?

    —
    You are receiving this because you modified the open/close state.
    Reply to this email directly or view it on GitHub
    #1520 (comment)
14. isaacabraham commented on Mar 16, 2016

    

    isaacabraham

    on Mar 16, 2016

    ContributorAuthor

    More actions

    Hmmm. Yes that works as well although not quite what I'm thinking, which is more "don't go above 'major' version of transitive dependencies".

    • A = 1.2.3
    • A depends on B >= 1.2.3
    • I don't want B to ever go >= 2.0

    I guess this is more about the package author of A (not specifying deps version boundaries tightly enough) than paket though, right?
15. forki commented on Mar 16, 2016

    

    forki

    on Mar 16, 2016

    Member

    More actions

    yes that is something that can't be really expressed in nuget
16. forki

    added 2 commits that reference this issue on Mar 17, 2016

    Revert #1520

    de5303d

    Revert #1520

    e58ca0b