Repository navigation
When adding framework specification to paket.dependencies .props include is moved to the bottom of csproj file #1487
Description
I have a nuget package that includes both a .props and a .targets. Then I wantet to specify which frameworks should be included when installting packages.
Added framework specification
framework: net40, net45, net46
source nuget_repo
nuget MultiTarget
nuget Dapper
nuget NUnit
After this the .props include statement was moved to the bottom just before .targets import
Reproduced in repo paket_bug with latest commit
Just run reproduce.bat
Reproduced on
Activity
forki commentedon Mar 10, 2016
#1233 shows that it should not go to the top since it contains a property that is defined later.
forki commentedon Mar 10, 2016
I'm reverting this for now since the fix was obviously incorrect. But what would be a correct fix?
/cc @inosik
Revert #1487
inosik commentedon Mar 11, 2016
The problem is that Paket generates a
__paket__xyz_propsproperty for.props(and.targets) that aren't framework specific, when there is a framework restriction. So (I think) we should handle this special case when we generate the<Choose />-blocks for the contents of the package.forki commentedon Mar 11, 2016
the question is: is @theggelund's csproj file broken or is it just "different" after adding the framework specification.
inosik commentedon Mar 11, 2016
It's not broken, it's different to what NuGet would generate.
forki commentedon Mar 11, 2016
But the issue got opened here. So I assumed the generated xml was not working
theggelund commentedon Mar 12, 2016
after adding the framework specification the .props got moved to the bottom of csproj. It's not framework specific or anything. Is it being processed as framework specific and with no specification? (how would you specify this if that's the case?) It just got moved and I think that's the bug.