Repository navigation
Regression: empty <runtime> section generated in config files #1081
Description
While executing "paket.exe install" command for all projects affected paket adds empty section
even though we have "redirects: off" at the top of paket.dependencies file.
I don't remember seeing it with the version from a couple weeks ago, so it looks like regression.
Activity
forki commentedon Sep 22, 2015
/cc @isaacabraham
On Sep 22, 2015 17:42, "konste" notifications@github.com wrote:
isaacabraham commentedon Sep 22, 2015
Not sure how that can be then - the changes related to adding new config file etc. only run from within the redirects code as far as I know.
Maybe this has to do with the changes to allow redirects against dependencies?
konste commentedon Sep 22, 2015
-- Maybe this has to do with the changes to allow redirects against dependencies?
As far as I understand that's what it is.
isaacabraham commentedon Sep 22, 2015
I have no clue where that change came from - happy to have a look around through the code base when I get some time.
konste commentedon Sep 22, 2015
It is not urgent. Let me know if it does repro for you.
konste commentedon Sep 25, 2015
@mrinaldi I think it is your change to BindingRedirects.fs 5 days ago introduced that regression. The problem is in applyBindingRedirects method. It updates configuration files even when no binding redirects required there or binding redirects globally disabled.
The issue is cosmetic, but very annoying.
I don't know F# unfortunately, so I cannot provide meaningful PR. Could you please fix it?
Thank you!
Konstantin
Proposed fix for fsprojects#1081 - do not touch config files when the…
Merge pull request #1092 from konste/master
mrinaldi commentedon Sep 28, 2015
Sorry @konste, I'm on vacation and I can't access my computer in the meanwhile.
Anyway, thanks for fixing it.