Skip to content

Dual SQL Client driver code changes #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smoothdeveloper merged 14 commits into from
May 7, 2026
Merged

Dual SQL Client driver code changes #482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b46387f
bringing code changes from @daniellittledev (https://github.com/danie…
smoothdeveloper Mar 29, 2026
cfb5c79
generate separate assemblyinfo for Microsoft.Data.SqlClient projects
smoothdeveloper Apr 1, 2026
bcec095
fix internals visible to in designtime assembly and adjust paket.refe…
smoothdeveloper Apr 1, 2026
c90ef2a
* adjust build so MicrosoftSqlClient assemblies info have proper asse…
smoothdeveloper May 2, 2026
f6f7b70
* fix assembly replacement map given to TypeProviderForNamespaces con…
smoothdeveloper May 5, 2026
ddb0daf
fix more naked references to System.Data.SqlClient in tests
smoothdeveloper May 5, 2026
2ac723a
update FSharp.TypeProvider sdk to latest bits
smoothdeveloper May 5, 2026
ce3a2b2
adjust aliases for SqlMetaData and SqlDataRecord, makes all test compile
smoothdeveloper May 5, 2026
ed24def
SqlDataRecord reflection resolution is different depending the SqlCli…
smoothdeveloper May 6, 2026
55cccc1
refactor build script to build and run tests for both drivers. Remain…
smoothdeveloper May 6, 2026
26fcb63
keep nuget client in packages folder
smoothdeveloper May 6, 2026
9f4cc5a
nuspec for the Microsoft.Data.SqlClient version, separate build outpu…
smoothdeveloper May 6, 2026
f5081e4
fix namespace for type providers to be under FSharp.Data.SqlClient ra…
smoothdeveloper May 7, 2026
fbfba0c
remove legacy namespace compatibility, adjust release notes
smoothdeveloper May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix internals visible to in designtime assembly and adjust paket.refe… 
…rences in sqlservertypes.tests projects
  • Loading branch information
@smoothdeveloper
smoothdeveloper committed Apr 1, 2026
commit bcec0957b24aa1721b3d80dfe17e56c654398e7e
5 changes: 5 additions & 0 deletions src/SqlClient.DesignTime/SqlCommandProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ open FSharp.Data.SqlClient.Internals
open ProviderImplementation.ProvidedTypes

[<assembly:TypeProviderAssembly()>]
#if SYSTEM_DATA_SQLCLIENT
[<assembly:InternalsVisibleTo("SqlClient.DesignTime.Tests")>]
#endif
#if MICROSOFT_DATA_SQLCLIENT
[<assembly:InternalsVisibleTo("MicrosoftSqlClient.DesignTime.Tests")>]
#endif
do()

#if USE_SQL_SERVER_TYPES_ASSEMBLY
Expand Down
4 changes: 2 additions & 2 deletions ...ient.SqlServerTypes.Tests/MicrosoftSqlClient.SqlServerTypes.Tests.fsproj.paket.references
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
group Test
FSharp.Core
System.Data.SqlClient
System.Configuration.ConfigurationManager
Microsoft.SqlServer.Types redirects: force
Microsoft.Data.SqlClient
Microsoft.SqlServer.Types redirects: force
Newtonsoft.Json
xunit
xunit.runner.visualstudio
2 changes: 1 addition & 1 deletion tests/SqlClient.SqlServerTypes.Tests/SqlClient.SqlServerTypes.Tests.fsproj.paket.references
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FSharp.Core
System.Data.SqlClient
System.Configuration.ConfigurationManager
Microsoft.SqlServer.Types redirects: force
Microsoft.SqlServer.Types redirects: force
Newtonsoft.Json
xunit
xunit.runner.visualstudio
8 changes: 0 additions & 8 deletions tests/SqlClient.SqlServerTypes.Tests/paket.references
View file
Open in desktop

This file was deleted.

Loading