Repository navigation
Removed the test helpers nothing uses - #636
Open
xperiandri wants to merge 1 commit into
Open
xperiandri wants to merge 1 commit into
xperiandri wants to merge 1 commit into
Conversation
The xUnit test projects carried helpers that no test calls any more, and four input test files kept private copies of a helper that `Helpers.fs` already provides. - `Helpers.fs`: `isType`, `isSeq`, `isDict`, `isNameValueDict`, `wantSome`, `wantNone`, `noErrors`, `throwsAsync`, `(<??)`, `undefined`, `setEvent`, `resetEvent` and `waitEvent` - `ErrorHelpers.fs`: `ensureExecutionError`; the integration tests' `Helpers.fs`: `hasItems` - The copies of `stringifyArg` and `stringifyInput` in `InputEnumTests`, `InputListTests`, `InputNestedTests` and `InputNullableStringTests`, identical to the ones in `Helpers.fs` - `Packages.props`: the entries no project references, `BenchmarkDotNet.Annotations`, `xunit.analyzers` and `xunit.v3.assert`, `.core`, `.extensibility.core`, `.runner.console` and `.runner.utility` `hasErrorAtPath` stays: no test calls it yet, but the Relay hardening in progress does. The number of tests is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removed definitions are unreferenced, and the consolidated helpers are equivalent and available before all affected test modules.
0 open findings
What changed in this PR
Removes unused test helpers and redundant package version entries while consolidating input serialization helpers.
Changes:
- Removed unused unit and integration test helpers.
- Reused shared input-stringification helpers across four test modules.
- Removed unreferenced package entries from central package management.
| File | Description |
|---|---|
Packages.props |
Removes unused package version entries. |
tests/FSharp.Data.GraphQL.Tests/Helpers.fs |
Removes unused shared test helpers. |
tests/FSharp.Data.GraphQL.Tests/ErrorHelpers.fs |
Removes an unused execution-error helper. |
tests/FSharp.Data.GraphQL.IntegrationTests/Helpers.fs |
Removes an unused collection helper. |
tests/FSharp.Data.GraphQL.Tests/Variables and Inputs/InputEnumTests.fs |
Uses shared stringification helpers. |
tests/FSharp.Data.GraphQL.Tests/Variables and Inputs/InputListTests.fs |
Uses shared stringification helpers. |
tests/FSharp.Data.GraphQL.Tests/Variables and Inputs/InputNestedTests.fs |
Uses shared helpers and removes an unnecessary import. |
tests/FSharp.Data.GraphQL.Tests/Variables and Inputs/InputNullableStringTests.fs |
Uses shared stringification helpers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 9 files 9 suites 14m 45s ⏱️ Results for commit bfd2be5. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the first MSTest projects arrive, the xUnit test projects drop what no test uses.
Changes
Helpers.fs:isType,isSeq,isDict,isNameValueDict,wantSome,wantNone,noErrors,throwsAsync,(<??),undefined,setEvent,resetEventandwaitEvent;ErrorHelpers.fs:ensureExecutionError;Helpers.fs:hasItems.InputEnumTests,InputListTests,InputNestedTestsandInputNullableStringTestskept private copies ofstringifyArgandstringifyInput, identical to the ones inHelpers.fs. They now use the shared ones.Packages.props: removed the entries no project references:BenchmarkDotNet.Annotations,xunit.analyzers,xunit.v3.assert,xunit.v3.core,xunit.v3.extensibility.core,xunit.v3.runner.consoleandxunit.v3.runner.utility.Kept on purpose:
hasErrorAtPath: no test ondevcalls it yet, but a pending Relay change does.TraitTypeandTraitNameinTestAttributes.fs: the ObjectListFilter and LINQ tests use them.Each removed helper and package was searched for on
devand on every branch active since June 2026, so merging those branches does not break the build.Tests
The number of tests is unchanged. FAKE runs:
🤖 Generated with Claude Code