Skip to content

Bounded the memory a graphql-transport-ws client can make the server hold #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xperiandri wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Bounded the memory a graphql-transport-ws client can make the server hold #631

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6094c78
Fixed unbounded buffering of incoming graphql-transport-ws messages
xperiandri Oct 3, 2026
f98cc28
Bounded what a graphql-transport-ws connection holds for a slow client
xperiandri Oct 10, 2026
5ffe3a1
Used the named close codes and specific assertions in the WebSocket c…
xperiandri Oct 10, 2026
af1fc52
Opened the namespaces instead of qualifying names in the WebSocket co…
xperiandri Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Opened the namespaces instead of qualifying names in the WebSocket co… 
…nnection tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
  • Loading branch information
@xperiandri @claude
xperiandri and claude committed Oct 10, 2026
commit af1fc52b5612639ae53a4b9d493b1f4a05e9cbbf
6 changes: 4 additions & 2 deletions tests/FSharp.Data.GraphQL.Tests/AspNetCore/WebSocketConnectionTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ open System.Threading.Channels
open System.Threading.Tasks
open Microsoft.AspNetCore.Http
open Microsoft.Extensions.DependencyInjection
open Microsoft.Extensions.Hosting
open Microsoft.Extensions.Logging.Abstractions
open Microsoft.Extensions.Options
open Xunit

open FSharp.Data.GraphQL
open FSharp.Data.GraphQL.Server.AspNetCore
open FSharp.Data.GraphQL.Shared.WebSockets

Expand Down Expand Up @@ -121,7 +123,7 @@ type private Session = {
Scope : IDisposable
}

let private startConnectionWith (executor : FSharp.Data.GraphQL.Executor<Root>) (configure : GraphQLOptions<Root> -> GraphQLOptions<Root>) =
let private startConnectionWith (executor : Executor<Root>) (configure : GraphQLOptions<Root> -> GraphQLOptions<Root>) =
let services = ServiceCollection ()
services.AddLogging () |> ignore
services.AddGraphQL<Root> (executor, (fun _ -> { RequestId = "test" })) |> ignore
Expand Down Expand Up @@ -596,7 +598,7 @@ let ``A maximum message size that is not positive fails when the middleware is c
use _ = provider
let invalid = Options.Create { options with WebsocketOptions = { options.WebsocketOptions with MaxReceiveMessageSize = 0 } }
let lifetime =
{ new Microsoft.Extensions.Hosting.IHostApplicationLifetime with
{ new IHostApplicationLifetime with
member _.ApplicationStarted = CancellationToken.None
member _.ApplicationStopping = CancellationToken.None
member _.ApplicationStopped = CancellationToken.None
Expand Down
Loading