Skip to content

Fix CI silently skipping the integration test suite #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xperiandri merged 4 commits into from
Sep 15, 2026
Merged

Fix CI silently skipping the integration test suite #603

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8ee264
fixup! Publish CI test results into PR discussions, harden artifact d…
xperiandri Sep 15, 2026
fd93944
fixup! Publish CI test results into PR discussions, harden artifact d…
xperiandri Sep 15, 2026
7742cb1
fixup! Migrate integration tests to in-process hosts via `WebApplicat…
xperiandri Sep 15, 2026
bdada17
Give the remote Swapi provider tests their own operation names
xperiandri Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Migrate integration tests to in-process hosts via `WebApplicat… 
…ionFactory` and remove external server orchestration from build (#564)

Run the whole integration test suite again

The migration to in-process hosts dropped the `RunIntegrationTests`
target and left only `UpdateIntrospectionFile`, which filters to
`IntrospectionUpdateTests`. The client provider, operation error and
reserved scalar tests have not been run by the build pipeline since.

Restore a `RunIntegrationTests` target after `UpdateIntrospectionFile`
that runs every other integration test into its own results file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
  • Loading branch information
@xperiandri @claude
xperiandri and claude committed Sep 15, 2026
commit 7742cb10042b35c4a994782ba56fa89713affcf4
9 changes: 9 additions & 0 deletions build/Program.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,14 @@ Target.create UpdateIntrospectionFileTarget <| fun _ ->
"FSharp.Data.GraphQL.IntegrationTests.IntrospectionUpdate.trx"
(ValueSome "FullyQualifiedName~IntrospectionUpdateTests")

// Runs the rest of the integration tests; the introspection update tests already ran in UpdateIntrospectionFileTarget
let [<Literal>] RunIntegrationTestsTarget = "RunIntegrationTests"
Target.create RunIntegrationTestsTarget <| fun _ ->
runTests
integrationTestsProjectPath
"FSharp.Data.GraphQL.IntegrationTests.trx"
(ValueSome "FullyQualifiedName!~IntrospectionUpdateTests")

let unitTestsProjectPath =
"tests"
</> "FSharp.Data.GraphQL.Tests"
Expand Down Expand Up @@ -381,6 +389,7 @@ Target.create "PackAndPush" ignore
==> RunUnitTestsTarget
==> BuildIntegrationTestsTarget
==> UpdateIntrospectionFileTarget
==> RunIntegrationTestsTarget
==> "All"
=?> (GenerateDocsTarget, Environment.environVar "GITHUB_ACTIONS" = "True")
|> ignore
Expand Down