Skip to content

Fix a syntax typo - #4636

Closed
hroncok wants to merge 1 commit into
freeipa:masterfrom
hroncok:patch-1
Closed

hroncok wants to merge 1 commit into
freeipa:masterfrom
hroncok:patch-1

Conversation

@hroncok

@hroncok hroncok commented May 3, 2020

Copy link
Copy Markdown
Contributor

This worked for now, but is SyntaxError in Python 3.9.0a6:

  File "/usr/lib/python3.9/site-packages/ipapython/cookie.py", line 222
    return'/'
         ^
SyntaxError: invalid string prefix

(The Python change might actually be reverted before 3.9 final, but this can be fixed anyway.)

This worked for now, but is SyntaxError in Python 3.9.0a6:

  File "/usr/lib/python3.9/site-packages/ipapython/cookie.py", line 222
    return'/'
         ^
SyntaxError: invalid string prefix

(The Python change might actually be reverted before 3.9 final,
but this can be fixed anyway.)
@tiran tiran added ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 labels May 4, 2020

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@tiran tiran added the pushed Pull Request has already been pushed label May 4, 2020
@tiran

tiran commented May 4, 2020

Copy link
Copy Markdown
Member

master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants