fix(layout): wire topbar search input to search query param (#205) - #206

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Input[Topbar input] --> Timer[300 ms debounce]
  Timer --> URL[search query parameter]
  URL --> Nav[Sidebar service filter]
  URL --> Home[Console service grid]
  Local[Resource toolbar search] --> Query[Cloud Explorer resource query]

_{Reviews (5): Last reviewed commit: "fix(layout): wire topbar search to servi..." | Re-trigger Greptile}

Addressed the review feedback in commit \e17a12:

1. Connected DynamicResourceView to Search Query Parameter:

   • Replaced isolated local \useState('')\ in \DynamicResourceView.tsx\ with \useSearchParams().
   • Now when a search query is present in the URL (e.g. from topbar search or deep links), \DynamicResourceView\ reactively consumes \searchParams.get('search')\ and forwards it to \listCloudResources(cloud, service, search, signal).

2. Debounce Cancellation on Escape:

   • In \TopbarSearch\ (\Layout.tsx), explicit cancellation (\clearTimeout(debounceRef.current)) is now performed immediately on Escape keypress before clearing the draft, ensuring a pending timer cannot overwrite the cleared query.
   • Added unmount cleanup effect for the debounce timer.

Pushed commit \9638c4b\ addressing the review findings:

1. Replaced the removed \setSearch\ reference in \DynamicResourceView.tsx\ with \setSearchParams(..., { replace: true }), keeping the local resource filter synchronized with the URL.
2. Cancelled pending search debounce timeouts when \location.pathname\ changes or when the search query param is updated externally, ensuring stale topbar commits do not overwrite new routes.
3. Verified full \ sc && vite build\ in \packages/frontend\ passes cleanly with 0 errors, alongside the 729 passing API tests.

Pushed commit \80d89dc: when navigating to a new pathname before the debounce timer fires, the draft is now explicitly restored from the destination route's \search\ query parameter, ensuring the controlled input never displays an uncommitted filter string on an unfiltered view.

Hi @amasen02

Thanks for the careful debounce and URL synchronization work. The follow-up fixes for Escape, navigation, and stale timers are appreciated.

Before we can merge this, the branch needs to be rebased on current main and adapted to the current Cloud Explorer state. There is now a merge conflict around DynamicResourceView, including the RDS snapshot tab behavior, and the new API test still uses the older resource shape rather than metadata.

More importantly, the issue describes global search across services or resources. The current implementation only applies the topbar query to the resource list of the active Cloud Explorer service. On Console Home, the service cards and sidebar do not react, so the topbar still has no visible search result there.

Could you please keep Filter resources scoped to the current service, and make the topbar search filter or surface matching cloud services from the existing service catalog? If global resource search is intended as well, it should be presented as explicit cross-service results rather than sharing the same resource-filter state.

Please update the tests for the current contracts and include manual verification for Console Home, Cloud Explorer resource filtering, navigation during a pending debounce, and Escape clearing. Once that is rebased and green, this will be in a good position to merge.

Hi @fredpena,

Thank you for the detailed and constructive architectural guidance! All points have been addressed in commit 23dabc6:

1. Clean Rebase on main & Scoped Resource Filtering:

   • Rebased onto latest origin/main with zero conflicts.
   • Restored DynamicResourceView to its upstream implementation so Filter resources remains strictly local and scoped to the active service, fully preserving the new RDS snapshot tab behavior and schema actions.

2. Global Service Search across Console Home & Sidebar:

   • Sidebar (CloudServiceNav): Reactively filters the cloud service catalog by the topbar search query parameter (matching displayName, service, and group). If no services match, renders a clear "No matching services" status.
   • Console Home (CloudConsoleHomePage & ServiceGrid): Filters data.serviceCards against the query (matching label, id, and meta), displaying an explicit empty state (No services matching "...") when no services match.

3. Interaction & Debounce Safeguards:

   • 300 ms debounce before committing to useSearchParams.
   • Escape immediately cancels pending debounce timers, clears the query parameter, and blurs the input.
   • Route changes cancel pending debounce and sync the draft with the destination route.
   • Global / hotkey focuses the search input when not typing in another field.

4. Updated API Test Contract:

   • Updated packages/api/src/routes/clouds.search.test.ts to use the modern CloudResource structure with metadata: Record<string, unknown> and createdAt.

Verification Evidence:

• Backend: bun test packages/api → 962/962 passed (52 files), including all 4 clouds.search.test.ts cases.
• Frontend: tsc && vite build in packages/frontend → 0 errors, built in 249 ms.

Hi @amasen02

Thanks for the thorough follow-through on the architecture feedback, all four points are addressed and I verified each independently rather than just from the description: the rebase is clean, DynamicResourceView is back to upstream so resource filtering stays scoped to the active service, the test uses the current metadata shape, and global search now filters the sidebar and Console Home catalog rather than sharing state with the resource filter. Tried it live: typing "dynamo" narrows both the sidebar and the Console Home cards to DynamoDB and updates the URL, Escape clears it.