fix(dotnet-sdk): stop pagination on repeated next URLs - #4849
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The .NET SDK follows
nextURLs without remembering which pages it has requested. If an API response repeats a cursor,CrawlAsync,BatchScrapeAsync, and auto-paginated monitor checks request the same page indefinitely, append duplicate results, and never return unless externally cancelled.Change
Track requested pagination URLs for each operation and throw a
FirecrawlExceptionwhen a URL repeats, before making another HTTP request. This covers the crawl, batch scrape, and monitor-check paths without changing their successful pagination behavior.Reproduction and tests
A fake HTTP handler returned the same
nextURL on successive pages. The three new cases failed againstmain: each operation fetched the page again and hit the handler's guard. After the fix:Firecrawl.Testsproject: 70 passed, 0 failed.git diff --checkpassed.No API or wire format change.
Summary by cubic
Fixes the .NET SDK paginating indefinitely on repeated
nextURLs, which could loop forever and append duplicate results.FirecrawlExceptionbefore re-fetching a repeated page.CrawlAsync,BatchScrapeAsync, and monitor checks without changing successful pagination behavior.nextURL and one that progresses normally.Written for commit 44c9bad. Summary will update on new commits.