Skip to content

ci: build product e2e apps with Swift Package Manager - #18738

Draft
SelaseKay wants to merge 2 commits into
mainfrom
ci/product-e2e-spm
Draft

ci: build product e2e apps with Swift Package Manager#18738
SelaseKay wants to merge 2 commits into
mainfrom
ci/product-e2e-spm

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Product e2e jobs still install the Firebase Apple SDK with CocoaPods on macOS, and the functions and performance iOS jobs were held on CocoaPods after an older Xcode pin. An upcoming firebase-ios-sdk release is Swift Package Manager only, so those jobs need to build with SPM before that pin can move.

This adds a macos-spm input to the reusable macOS workflow. When it is set, the job enables Swift Package Manager and removes the example Podfile before the build, the same way the iOS job already does. The macOS product e2e jobs opt in, including messaging. The functions and performance iOS jobs drop their CocoaPods override and use the existing SPM default.

Crashlytics stays on CocoaPods. Its example build phase still runs a script under PODS_ROOT. The smoke apps and Data Connect are unchanged. The firebase-ios-sdk pin stays at 12.19.0.

Auth macOS still pod-installs facebook_auth_desktop, which has no macOS Package.swift. That job keeps the committed Podfile so CocoaPods does not regenerate one that targets RunnerTests.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • Confirm the macOS e2e jobs for ai, analytics, app check, database, Firestore, functions, messaging, ML model downloader, Remote Config, and storage run the SPM prep step and do not run pod install
  • Confirm the auth macOS job builds with SPM and still pod-installs facebook_auth_desktop from the committed Podfile
  • Confirm the functions and performance iOS jobs build with SPM
  • Confirm the Crashlytics iOS and macOS jobs still build with CocoaPods
  • Watch the messaging macOS job. The Swift integration build still removes that plugin before its own macOS SPM build

@SelaseKay
ci: build product e2e apps with Swift Package Manager
b33a3c5 
Move the macOS product jobs, including messaging, and the functions and performance iOS jobs onto SPM. Crashlytics stays on CocoaPods because its example still runs a script under PODS_ROOT.
@gemini-code-assist

gemini-code-assist Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
ci: fix macOS SPM e2e builds that still expected CocoaPods
b84a31e 
Messaging required the Pods xcconfig, and the database and ML model downloader examples had no Swift package integration, so Flutter resolved the plugin package before the generated symlink farm existed. Auth keeps its Podfile because facebook_auth_desktop has no macOS package.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellwheatley russellwheatley Awaiting requested review from russellwheatley russellwheatley will be requested when the pull request is marked ready for review russellwheatley is a code owner
@Lyokone Lyokone Awaiting requested review from Lyokone Lyokone will be requested when the pull request is marked ready for review Lyokone is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SelaseKay