Skip to content

fix(auth): harden parsing of server-provided reCAPTCHA config #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulb777 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(auth): harden parsing of server-provided reCAPTCHA config #16757

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28205d2
fix(auth): harden parsing of server-provided reCAPTCHA config
paulb777 Oct 1, 2026
880eb0f
refactor(auth): use hasPrefix for error reason check
paulb777 Oct 1, 2026
50aace3
refactor(auth): simplify reCAPTCHA enforcement state parsing
paulb777 Oct 1, 2026
20640bb
Merge remote-tracking branch 'origin/main' into pb-harden-auth-recapt…
paulb777 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(auth): use hasPrefix for error reason check 
Address review feedback: String.hasPrefix(_:) is the idiomatic way to check a string prefix, rather than the generic Sequence.starts(with:).
  • Loading branch information
@paulb777
paulb777 committed Oct 1, 2026
commit 880eb0f7e01d2cc8a8b7cdde0097c5bcddafed0d
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Backend/AuthBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ final class AuthBackend: AuthBackendProtocol {
if let underlyingErrors = errorDictionary["errors"] as? [Any] {
for case let underlyingError as [String: Any] in underlyingErrors {
if let reason = underlyingError["reason"] as? String {
if reason.starts(with: "keyInvalid") {
if reason.hasPrefix("keyInvalid") {
return AuthErrorUtils.invalidAPIKeyError()
}
if reason == "ipRefererBlocked" {
Expand Down
Loading