Skip to content

fix: Encode non-finite floats in feature server JSON responses #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zhuoxi2000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Encode non-finite floats in feature server JSON responses #6930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions sdk/python/feast/feature_server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@

import base64
import logging
import math
from datetime import datetime, timezone
from typing import Any, Dict, Optional
from typing import Any, Dict, Optional, Union

from feast.protos.feast.serving.ServingService_pb2 import GetOnlineFeaturesResponse
from feast.protos.feast.types.Value_pb2 import Value
Expand All @@ -23,18 +24,29 @@
4: "OUTSIDE_MAX_AGE",
}

_FLOAT_SCALAR_FIELDS = ("double_val", "float_val")
_FLOAT_COLLECTION_FIELDS = (
"double_list_val",
"float_list_val",
"double_set_val",
"float_set_val",
)


def convert_response_to_dict(response: GetOnlineFeaturesResponse) -> Dict[str, Any]:
"""Convert GetOnlineFeaturesResponse to a JSON-serializable dict.

Matches the structure produced by MessageToDict(proto, preserving_proto_field_name=True)
with proto_json.patch() applied, with one intentional difference:
with proto_json.patch() applied, with two intentional differences:

- double_val fields are returned as Python float objects (json.dumps uses Python 3.1+
shortest round-trip form, ~15-17 sig digits) rather than 18 fixed significant digits
(float_precision=18). Values are numerically identical; only the JSON string length
may differ. This is safe for all ML feature types and avoids unnecessary precision
overhead.
- Non-finite float values (NaN, +/-inf) are returned as the strings "NaN",
"Infinity" and "-Infinity" (the protobuf JSON mapping), because they are not
valid JSON numbers and would make JSONResponse fail the whole response.
"""
result: Dict[str, Any] = {
"results": [
Expand Down Expand Up @@ -77,6 +89,15 @@ def _value_to_native(v: Value) -> Optional[Any]:
which = v.WhichOneof("val")
if which is None or which == "null_val":
return None
# NaN/Infinity are not valid JSON numbers; JSONResponse (allow_nan=False)
# would fail the whole response, so encode them as protobuf JSON does.
elif which in _FLOAT_SCALAR_FIELDS:
return _float_to_native(getattr(v, which))
elif which in _FLOAT_COLLECTION_FIELDS:
vals = getattr(v, which).val
if all(map(math.isfinite, vals)):
return list(vals)
return [_float_to_native(f) for f in vals]
# bytes must be base64-encoded for JSON serialization
elif which == "bytes_val":
return base64.b64encode(v.bytes_val).decode("ascii")
Expand Down Expand Up @@ -114,6 +135,19 @@ def _value_to_native(v: Value) -> Optional[Any]:
return getattr(v, which)


def _float_to_native(f: float) -> Union[float, str]:
"""Return a finite float unchanged, or its protobuf JSON string form.

The protobuf JSON mapping encodes non-finite floats as the strings
"NaN", "Infinity" and "-Infinity", which keeps the response valid JSON.
"""
if math.isfinite(f):
return f
if math.isnan(f):
return "NaN"
return "Infinity" if f > 0 else "-Infinity"


def _zoned_timestamp_to_str(zoned) -> Optional[str]:
"""Convert a ZonedTimestamp proto to an ISO 8601 string in its stored zone.

Expand Down
Loading
Loading