fix: Compare batch_source in KafkaSource and KinesisSource equality - #6926
Open
Rodrigo-Palma wants to merge 1 commit into
Open
Rodrigo-Palma wants to merge 1 commit into
Rodrigo-Palma wants to merge 1 commit into
Conversation
Both __eq__ methods ignored batch_source, so apply_data_source treated a stream source whose batch source changed as unchanged and skipped the write. Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6926 +/- ##
==========================================
+ Coverage 48.62% 48.63% +0.01%
==========================================
Files 427 427
Lines 53845 53845
Branches 7844 7844
==========================================
+ Hits 26181 26188 +7
+ Misses 25797 25792 -5
+ Partials 1867 1865 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
KafkaSource.__eq__andKinesisSource.__eq__ignorebatch_source(PushSource.__eq__checks it).apply_data_sourceskips the write when the stored source is equal, so changing only the batch source of a stream source is silently not persisted.Which issue(s) this PR fixes:
None filed.
Checks
git commit -s)Testing Strategy
Misc
New test fails on master for both sources (unequal check and registry round trip) and passes with the fix.