fix: Keep tiling, offline and stream engine settings when copying a StreamFeatureView - #6924
Open
Rodrigo-Palma wants to merge 2 commits into
Open
Rodrigo-Palma wants to merge 2 commits into
Rodrigo-Palma wants to merge 2 commits into
Conversation
…treamFeatureView Signed-off-by: Rodrigo-Palma <email.rodrigopalma@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6924 +/- ##
=======================================
Coverage 48.62% 48.62%
=======================================
Files 427 427
Lines 53845 53845
Branches 7844 7844
=======================================
Hits 26181 26181
Misses 25797 25797
Partials 1867 1867
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
StreamFeatureView.__copy__doesn't passoffline,enable_tiling,tiling_hop_sizeorstream_engineto the constructor, so the copy falls back to the defaults. Sincewith_name,with_projectionand__getitem__all go through__copy__, a projected stream view silently loses tiling and its engine config.FeatureView.__copy__already passesoffline.The registry also uses
__copy__()to build the version snapshot forno_promote(registry.py:905), so that snapshot is saved without the tiling config.Which issue(s) this PR fixes:
N/A
Checks
git commit -s)Testing Strategy
Extended
test_stream_feature_view_copyto set these fields; it fails on master and passes with the fix.