Conversation
Signed-off-by: Halfnums <halfnums@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The development guide repeats
universal_online_storesfor both offline and online store selection. Document the existinguniversal_offline_stores(only=["bigquery"])anduniversal_online_stores(only=["sqlite"])markers and explain that they select separate dimensions of the integration test matrix.Which issue(s) this PR fixes:
No linked issue.
Checks
git commit -s).Testing Strategy
Validated against current
master(b8989cb0033b0d17248ab62ed839cf93cb5d1159). Executed the checkout's actualpytest_generate_testswith configuration and service boundaries stubbed. Verified the offlinebigquerymapping to the GCP provider and the onlinesqlitemapping to the local provider. Inspected both marker mappings and rangit diff --check. No cloud services or full integration matrix were run.Misc
Preparation was AI-assisted; the wording was checked against current parametrization code. Please apply the existing
kind/housekeepinglabel and authorize external-contributor CI withok-to-testif needed.