Conversation
Signed-off-by: raorer <2377183649@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The quick-start instructions create an environment with
uv venv --python 3.11, which defaults to.venv, but the following activation command points tovenv/bin/activate. Change it tosource .venv/bin/activateso the two steps agree.Which issue(s) this PR fixes:
No linked issue.
Checks
git commit -s)Testing Strategy
On macOS, created a fresh environment with
uv venv --python 3.11(Python 3.11.15). Confirmed the old activation path fails, the corrected path succeeds, andsys.prefixmatchesVIRTUAL_ENV. Applied the patch to current upstream master and rangit diff --check.The full SDK suite and documentation build were not run for this one-line command correction.
Misc
Prepared and validated with AI assistance. Please apply
kind/housekeepingand authorize upstream CI withok-to-testif needed.Release note: Correct the development quick-start virtual environment activation command.