test: Run MCP audit handler coroutines with asyncio.run - #6890
Merged
ntkathole merged 1 commit intoSep 29, 2026
Merged
Conversation
Signed-off-by: Alan Gauthier <alan.gauthier@jobteaser.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6890 +/- ##
==========================================
- Coverage 47.84% 47.84% -0.01%
==========================================
Files 422 422
Lines 52727 52727
Branches 7662 7662
==========================================
- Hits 25226 25225 -1
Misses 25680 25680
- Partials 1821 1822 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
tests/unit/audit/test_mcp_audit_handler.pyfails on master depending on test ordering (e.g. on PR #6789, all Python versions):RuntimeError: There is no current event loop in thread 'MainThread'._runhelper usesasyncio.get_event_loop(), which raises once a previous test on the same xdist worker has calledasyncio.run()(which unsets the loop), astest_precomputed_feature_vectors.pynow does since ce37029.asyncio.run(coro)so the tests no longer depend on a leftover event loop.Reproduce on master:
pytest tests/unit/test_precomputed_feature_vectors.py tests/unit/audit/test_mcp_audit_handler.py🤖 Generated with Claude Code