Conversation
The offline server is an Arrow Flight (gRPC) server, but its Service port was rendered with name "http" and no appProtocol. Protocol-aware meshes such as Istio then fall back to HTTP/1.1 and break gRPC traffic. Extend getServiceAppProtocol() to return "grpc" for OfflineFeastType, following the same pattern used for the registry gRPC Service. Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6869 +/- ##
=======================================
Coverage 47.66% 47.66%
=======================================
Files 422 422
Lines 52389 52389
Branches 7604 7604
=======================================
Hits 24971 24971
Misses 25625 25625
Partials 1793 1793
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ntkathole
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6866
The offline server talks gRPC (Arrow Flight), but the operator was creating its Service with a port named
httpand noappProtocol. So Istio treats it as HTTP/1.1 and gRPC calls go sideways.#6367 already fixed this for the registry. This just extends the same check in
getServiceAppProtocol()to cover the offline Service too, so it now getsappProtocol: grpc.Also updated the old test that expected
nilfor offline, and added one that renders the actual offline Service and checks the port.