-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Implemented registry refresh action feature #6657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ntkathole
merged 8 commits into
feast-dev:master
from
AdityaPatil22:fix/new-project-display-SQL-reg
Jul 31, 2026
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1669c7e
fix: Updated projects-list.json in order to display newly added projects
df39c55
fix: Bypass registry cache for projects-list endpoint
86a8dca
feat: Added registry refresh button in UI
d24c95f
fix: Move UI registry refresh button to layout header
0fe4725
fix: Moved registry refresh endpoint to REST and refactored UI refresh
a740aa2
fix: Enforced UPDATE permission on REST registry refresh
6e87a22
fix: Moved registry refresh endpoint to dedicated router
a55de3c
fix: Serve projects-list.json dynamically instead of writing static f…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Moved registry refresh endpoint to REST and refactored UI refresh
Signed-off-by: Aditya Patil <adpatil@redhat.com>
- Loading branch information
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import React, { useContext } from "react"; | ||
|
|
||
| interface RegistryRefreshContextInterface { | ||
| refreshing: boolean; | ||
| handleRefresh: () => Promise<void>; | ||
| } | ||
|
|
||
| const RegistryRefreshContext = React.createContext< | ||
| RegistryRefreshContextInterface | undefined | ||
| >(undefined); | ||
|
|
||
| const useRegistryRefreshContext = () => { | ||
| const ctx = useContext(RegistryRefreshContext); | ||
| if (!ctx) { | ||
| throw new Error( | ||
| "useRegistryRefreshContext must be used within RegistryRefreshContext.Provider", | ||
| ); | ||
| } | ||
| return ctx; | ||
| }; | ||
|
|
||
| export { RegistryRefreshContext, useRegistryRefreshContext }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import { useCallback, useContext, useState } from "react"; | ||
| import { useQueryClient } from "react-query"; | ||
| import { | ||
| ProjectListContext, | ||
| ProjectsListSchema, | ||
| } from "../contexts/ProjectListContext"; | ||
|
|
||
| interface Toast { | ||
| id: string; | ||
| title: string; | ||
| color: "success" | "danger"; | ||
| iconType: string; | ||
| } | ||
|
|
||
| const useRegistryRefresh = () => { | ||
| const [refreshing, setRefreshing] = useState(false); | ||
| const [toasts, setToasts] = useState<Toast[]>([]); | ||
| const queryClient = useQueryClient(); | ||
| const projectListCtx = useContext(ProjectListContext); | ||
| const basename = projectListCtx?.basename || ""; | ||
|
|
||
| const removeToast = useCallback((removedToast: { id: string }) => { | ||
| setToasts((prev) => prev.filter((t) => t.id !== removedToast.id)); | ||
| }, []); | ||
|
|
||
| const handleRefresh = useCallback(async () => { | ||
| setRefreshing(true); | ||
| try { | ||
| const refreshRes = await fetch(`${basename}/api/v1/registry/refresh`, { | ||
|
ntkathole marked this conversation as resolved.
|
||
| method: "POST", | ||
| }); | ||
| if (!refreshRes.ok) { | ||
| throw new Error(`Registry refresh failed (${refreshRes.status})`); | ||
| } | ||
| const res = await fetch(`${basename}/projects-list.json`, { | ||
| headers: { "Content-Type": "application/json" }, | ||
| }); | ||
| if (!res.ok) { | ||
| throw new Error(`Failed to fetch project list (${res.status})`); | ||
| } | ||
| const json = await res.json(); | ||
| const parsed = ProjectsListSchema.parse(json); | ||
| queryClient.setQueryData("feast-projects-list", parsed); | ||
| await queryClient.invalidateQueries("registry-rest-bulk"); | ||
| setToasts((prev) => [ | ||
| ...prev, | ||
| { | ||
| id: String(Date.now()), | ||
| title: "Refresh successful", | ||
| color: "success" as const, | ||
| iconType: "check", | ||
| }, | ||
| ]); | ||
| } catch { | ||
| setToasts((prev) => [ | ||
| ...prev, | ||
| { | ||
| id: String(Date.now()), | ||
| title: "Refresh failed", | ||
| color: "danger" as const, | ||
| iconType: "alert", | ||
| }, | ||
| ]); | ||
| } finally { | ||
| setRefreshing(false); | ||
| } | ||
| }, [basename, queryClient]); | ||
|
|
||
| return { refreshing, toasts, handleRefresh, removeToast }; | ||
| }; | ||
|
|
||
| export default useRegistryRefresh; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.