-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(server): Remote Materialization #6649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ntkathole
merged 13 commits into
feast-dev:master
from
aniketpalu:feat/remote-materialize-v2
Aug 6, 2026
+619
−58
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f61be7d
feat(server): Add async materialization via ?async=true query param
aniketpalu 9e121fc
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu 6c3aaa7
feat(server): Add async materialization via ?async=true query param
aniketpalu 1384c60
feat(sdk): Auto-delegate materialize to feature server when online_st…
aniketpalu 9a97b70
fix: Conflicts resolved
aniketpalu b5cb173
fix(server): Let store own MATERIALIZING transitions on async path
aniketpalu dc6f965
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu d8e7a99
fix: Address #6649 review — run_async, race reserve, version threading
aniketpalu 059c2d2
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu c602fe3
fix(server): Only reset MATERIALIZING FVs on async materialize failure
aniketpalu 7909fc4
fix: Default run_async to False and cover version forwarding
aniketpalu b8aa6e7
Merge branch 'master' into feat/remote-materialize-v2
aniketpalu a2810c8
fix(server): Use dedicated executor for async materialize
aniketpalu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(sdk): Auto-delegate materialize to feature server when online_st…
…ore is remote When online_store.type == remote, materialize() and materialize_incremental() POST to the feature server with ?async=true (fire-and-forget) instead of running the engine locally. Optional force=True maps to ?force=true for stuck MATERIALIZING recovery. URL/TLS/auth come from online_store config. Shared _delegate_remote_materialize() builds query params and posts; RemoteComputeEngine remains a follow-up for provider-layer remoting. Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
- Loading branch information
commit 1384c604650fa7a2e2ea6838dde98a81cdcebc16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be allow user to pass param, There's no way for an SDK user to do synchronous materialization now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — added
run_async: bool = Trueonmaterialize()/materialize_incremental().run_async=True: remote topology POSTs with?async=true, returns after 202run_async=False: POSTs without async and blocks until the server finishes sync materializationforce=Truestill requiresrun_async=True(force only applies on the async path)