Skip to content

feat(operator): Auto-create RBAC for spark_application batch engine #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
Jul 18, 2026
Merged

feat(operator): Auto-create RBAC for spark_application batch engine #6597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c6f4387
feat(operator): auto-create RBAC for spark_application batch engine
aniketpalu Jul 9, 2026
d1b3f50
fix(operator): bake default batch-driver SA into feature_store.yaml
aniketpalu Jul 14, 2026
a769e04
fix(operator): inject batch-driver SA only for spark_application
aniketpalu Jul 16, 2026
eaded80
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 16, 2026
1512284
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 17, 2026
f849569
chore(operator): fix CI fmt and secrets baseline
aniketpalu Jul 17, 2026
05feaa1
Merge branch 'master' into feat/operator-batch-engine-rbac
aniketpalu Jul 18, 2026
3c00206
refactor(operator): parse batch-engine ConfigMap once per reconcile
aniketpalu Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(operator): auto-create RBAC for spark_application batch engine 
Reconcile server/driver Roles from an embedded YAML template so FeatureStore
materialization works without manual SA/Role setup. Widen the operator
ClusterRole only as needed to grant those permissions (including
deletecollection for Spark driver cleanup).

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu
aniketpalu committed Jul 9, 2026
commit c6f4387cb4e962f5e43d432169afad2c0738a658
49 changes: 46 additions & 3 deletions infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2026-06-13T11:22:06Z"
createdAt: "2026-07-09T20:32:45Z"
operators.operatorframework.io/builder: operator-sdk-v1.41.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.64.0
Expand Down Expand Up @@ -180,11 +180,11 @@ spec:
resources:
- configmaps
- persistentvolumeclaims
- serviceaccounts
- services
verbs:
- create
- delete
- deletecollection
- get
- list
- update
Expand All @@ -193,18 +193,45 @@ spec:
- ""
resources:
- namespaces
- pods
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods
verbs:
- create
- delete
- deletecollection
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods/exec
verbs:
- create
- apiGroups:
- ""
resources:
- pods/log
verbs:
- get
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- update
- watch
- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -246,6 +273,14 @@ spec:
- patch
- update
- watch
- apiGroups:
- config.openshift.io
resources:
- apiservers
verbs:
- get
- list
- watch
- apiGroups:
- feast.dev
resources:
Expand Down Expand Up @@ -321,6 +356,14 @@ spec:
- list
- update
- watch
- apiGroups:
- sparkoperator.k8s.io
resources:
- sparkapplications
verbs:
- create
- delete
- get
- apiGroups:
- authentication.k8s.io
resources:
Expand Down
39 changes: 37 additions & 2 deletions infra/feast-operator/config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ rules:
resources:
- configmaps
- persistentvolumeclaims
- serviceaccounts
- services
verbs:
- create
- delete
- deletecollection
- get
- list
- update
Expand All @@ -22,18 +22,45 @@ rules:
- ""
resources:
- namespaces
- pods
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods
verbs:
- create
- delete
- deletecollection
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods/exec
verbs:
- create
- apiGroups:
- ""
resources:
- pods/log
verbs:
- get
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- update
- watch
- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -158,3 +185,11 @@ rules:
- list
- update
- watch
- apiGroups:
- sparkoperator.k8s.io
resources:
- sparkapplications
verbs:
- create
- delete
- get
39 changes: 37 additions & 2 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22033,11 +22033,11 @@ rules:
resources:
- configmaps
- persistentvolumeclaims
- serviceaccounts
- services
verbs:
- create
- delete
- deletecollection
- get
- list
- update
Expand All @@ -22046,18 +22046,45 @@ rules:
- ""
resources:
- namespaces
- pods
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods
verbs:
- create
- delete
- deletecollection
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods/exec
verbs:
- create
- apiGroups:
- ""
resources:
- pods/log
verbs:
- get
- apiGroups:
- ""
resources:
- serviceaccounts
verbs:
- create
- delete
- get
- list
- update
- watch
- apiGroups:
- apps
resources:
Expand Down Expand Up @@ -22182,6 +22209,14 @@ rules:
- list
- update
- watch
- apiGroups:
- sparkoperator.k8s.io
resources:
- sparkapplications
verbs:
- create
- delete
- get
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
Expand Down
8 changes: 6 additions & 2 deletions infra/feast-operator/internal/controller/featurestore_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,14 @@ type FeatureStoreReconciler struct {
// +kubebuilder:rbac:groups=feast.dev,resources=featurestores/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=feast.dev,resources=featurestores/finalizers,verbs=update
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;create;update;watch;delete
// +kubebuilder:rbac:groups=core,resources=services;configmaps;persistentvolumeclaims;serviceaccounts,verbs=get;list;create;update;watch;delete
// +kubebuilder:rbac:groups=core,resources=services;configmaps;persistentvolumeclaims,verbs=get;list;create;update;watch;delete;deletecollection
// +kubebuilder:rbac:groups=core,resources=serviceaccounts,verbs=get;list;create;update;watch;delete
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles;rolebindings;clusterroles;clusterrolebindings;subjectaccessreviews,verbs=get;list;create;update;watch;delete
// +kubebuilder:rbac:groups=core,resources=secrets;pods;namespaces,verbs=get;list;watch
// +kubebuilder:rbac:groups=core,resources=secrets;namespaces,verbs=get;list;watch
// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch;create;delete;deletecollection
// +kubebuilder:rbac:groups=core,resources=pods/exec,verbs=create
// +kubebuilder:rbac:groups=core,resources=pods/log,verbs=get
// +kubebuilder:rbac:groups=sparkoperator.k8s.io,resources=sparkapplications,verbs=create;get;delete
// +kubebuilder:rbac:groups=authentication.k8s.io,resources=tokenreviews,verbs=create
// +kubebuilder:rbac:groups=route.openshift.io,resources=routes,verbs=get;list;create;update;watch;delete
// +kubebuilder:rbac:groups=batch,resources=cronjobs,verbs=get;list;watch;create;update;patch;delete
Expand Down
Loading
Loading