Skip to content

fix: Add project filter to apply_data_source and delete_data_source #6319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mailtoboggavarapu-coder wants to merge 5 commits into from
Closed

fix: Add project filter to apply_data_source and delete_data_source #6319

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ec316e
fix: Add project filter to apply_data_source and delete_data_source (…
mailtoboggavarapu-coder Apr 22, 2026
8a65e52
test: add cross-project isolation tests for apply/delete_data_source
mailtoboggavarapu-coder Apr 22, 2026
3bcaf45
fix: restore em-dash in comment (encoding corruption)
mailtoboggavarapu-coder Apr 22, 2026
d9da8e6
fix: restore right-arrow characters corrupted by encoding (lines 706,…
mailtoboggavarapu-coder Apr 22, 2026
4264e9c
Merge branch 'master' into fix/apply-data-source-project-filter-v2
mailtoboggavarapu-coder Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: restore right-arrow characters corrupted by encoding (lines 706,… 
… 747)
  • Loading branch information
@mailtoboggavarapu-coder
mailtoboggavarapu-coder authored Apr 22, 2026
commit d9da8e6af29faa623831e0b8441d5ddddd5bc427
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/registry/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ def apply_feature_view(
record = self._get_version_record(feature_view.name, project, pin_version)

if record is not None:
# Version exists → pin/revert to that snapshot
# Version exists → pin/revert to that snapshot
# Check that the user hasn't also modified the definition.
# Compare user's FV (with version="latest") against active FV.
self._prepare_registry_for_changes(project)
Expand Down Expand Up @@ -744,7 +744,7 @@ def apply_feature_view(
# Apply the restored FV using the standard path below
feature_view = restored_fv
else:
# Version doesn't exist → forward declaration: create it
# Version doesn't exist → forward declaration: create it
feature_view.current_version_number = pin_version
feature_view_proto = feature_view.to_proto()
feature_view_proto.spec.project = project
Expand Down
Loading