Skip to content

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 8 commits into from
May 1, 2026
Merged

fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling #6315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca2c12c
fix: Use set() instead of [] for set-typed variables in SnowflakeRegi…
jials Apr 10, 2026
5c50fdb
fix: Resolve init ordering, infinite recursion, and column casing bug…
jials Apr 10, 2026
0e85d62
test: Add snowflake_registry fixture to integration registry tests
jials Apr 10, 2026
7b5c8ff
ci: Add snowflake_registry to CI filter and exclude from non-Snowflak…
jials Apr 10, 2026
945d7a9
fix: Remove leftover private key kwargs before passing to snowflake.c…
jials Apr 10, 2026
025c5b1
fix: correct set type hints in _sync_feast_metadata_to_projects_table
jials Apr 22, 2026
a8739a8
fix: resolve mypy type errors in SnowflakeRegistry cache
jials Apr 22, 2026
00f5869
test: add xdist_group mark to snowflake_registry
jials Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Use set() instead of [] for set-typed variables in SnowflakeRegi… 
…stry._sync_feast_metadata_to_projects_table

Signed-off-by: Jia Le <5955220+jials@users.noreply.github.com>
  • Loading branch information
@jials @ntkathole
jials authored and ntkathole committed May 1, 2026
commit ca2c12c78297a7f760b834f0657fb248351f3fa7
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/registry/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ def __init__(
self.project = project

def _sync_feast_metadata_to_projects_table(self):
feast_metadata_projects: set = []
projects_set: set = []
feast_metadata_projects: set = set()
projects_set: set = set()

with GetSnowflakeConnection(self.registry_config) as conn:
query = (
Expand Down
85 changes: 85 additions & 0 deletions sdk/python/tests/unit/infra/registry/test_snowflake_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,88 @@ def simulated_snowflake(conn, query):
f"feast#6208: UPDATE WHERE clause references {project_a!r} — unintended cross-project write.\n"
f"Query: {update_query}"
)


class TestSyncFeastMetadataToProjectsTable:
def _make_registry(self):
"""Create a SnowflakeRegistry with mocked __init__."""
with patch.object(SnowflakeRegistry, "__init__", lambda self: None):
registry = SnowflakeRegistry()
registry.registry_config = MagicMock()
registry.registry_path = "test_db.test_schema"
registry.purge_feast_metadata = False
return registry

@patch(
"feast.infra.registry.snowflake.GetSnowflakeConnection",
)
@patch("feast.infra.registry.snowflake.execute_snowflake_statement")
def test_sync_with_feast_metadata_projects(self, mock_execute, mock_get_conn):
registry = self._make_registry()

metadata_df = pd.DataFrame({"PROJECT_ID": ["project_a", "project_b"]})
projects_df = pd.DataFrame({"PROJECT_ID": ["project_a"]})

mock_cursor = MagicMock()
mock_cursor.fetch_pandas_all.side_effect = [metadata_df, projects_df]
mock_execute.return_value = mock_cursor

mock_conn = MagicMock()
mock_get_conn.return_value.__enter__ = MagicMock(return_value=mock_conn)
mock_get_conn.return_value.__exit__ = MagicMock(return_value=False)

with patch.object(registry, "apply_project") as mock_apply:
registry._sync_feast_metadata_to_projects_table()

mock_apply.assert_called_once()
applied_project = mock_apply.call_args[0][0]
assert applied_project.name == "project_b"

@patch(
"feast.infra.registry.snowflake.GetSnowflakeConnection",
)
@patch("feast.infra.registry.snowflake.execute_snowflake_statement")
def test_sync_with_no_feast_metadata(self, mock_execute, mock_get_conn):
registry = self._make_registry()

empty_df = pd.DataFrame({"PROJECT_ID": []})
mock_cursor = MagicMock()
mock_cursor.fetch_pandas_all.return_value = empty_df
mock_execute.return_value = mock_cursor

mock_conn = MagicMock()
mock_get_conn.return_value.__enter__ = MagicMock(return_value=mock_conn)
mock_get_conn.return_value.__exit__ = MagicMock(return_value=False)

with patch.object(registry, "apply_project") as mock_apply:
registry._sync_feast_metadata_to_projects_table()

mock_apply.assert_not_called()

@patch(
"feast.infra.registry.snowflake.GetSnowflakeConnection",
)
@patch("feast.infra.registry.snowflake.execute_snowflake_statement")
def test_sync_deduplicates_project_ids(self, mock_execute, mock_get_conn):
"""Sets should deduplicate project IDs; lists would not."""
registry = self._make_registry()

metadata_df = pd.DataFrame(
{"PROJECT_ID": ["project_a", "project_a", "project_b"]}
)
projects_df = pd.DataFrame({"PROJECT_ID": []})

mock_cursor = MagicMock()
mock_cursor.fetch_pandas_all.side_effect = [metadata_df, projects_df]
mock_execute.return_value = mock_cursor

mock_conn = MagicMock()
mock_get_conn.return_value.__enter__ = MagicMock(return_value=mock_conn)
mock_get_conn.return_value.__exit__ = MagicMock(return_value=False)

with patch.object(registry, "apply_project") as mock_apply:
registry._sync_feast_metadata_to_projects_table()

assert mock_apply.call_count == 2
applied_names = {call[0][0].name for call in mock_apply.call_args_list}
assert applied_names == {"project_a", "project_b"}