Skip to content

feat: Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 4 commits into from
May 1, 2026
Merged

feat: Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser #6240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d257265
feat(operator): Provision minimal TokenReview RBAC for OIDC auth
aniketpalu Apr 27, 2026
3ed93f1
fix: Add ManagedByLabelKey to shared OIDC ClusterRole labels
aniketpalu Apr 29, 2026
382e38b
fix: Add Get-first check to cleanupKubernetesClusterRbac
aniketpalu Apr 30, 2026
efc6d87
Updated .secret.baseline
aniketpalu Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(operator): Provision minimal TokenReview RBAC for OIDC auth 
When authz: oidc is configured, the operator now provisions a dedicated
feast-oidc-token-review ClusterRole and per-instance ClusterRoleBinding
with tokenreviews/create permission for SA token delegation.
Changes:
- Add OIDC status condition (AuthorizationReadyType) for feature parity
  with Kubernetes auth
- Use instance-independent labels for shared ClusterRole to avoid
  misleading audit trails when multiple FeatureStores use OIDC
- Clean up Kubernetes ClusterRoleBinding when switching auth types
- Add test coverage for OIDC RBAC creation and cleanup

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu @ntkathole
aniketpalu authored and ntkathole committed May 1, 2026
commit d25726595eb63ed238e592212af212f1feb29e92
6 changes: 5 additions & 1 deletion .secrets.baseline
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions infra/feast-operator/api/v1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const (
ClientFailedReason = "ClientDeploymentFailed"
CronJobFailedReason = "CronJobDeploymentFailed"
KubernetesAuthzFailedReason = "KubernetesAuthorizationDeploymentFailed"
OidcAuthzFailedReason = "OidcAuthorizationDeploymentFailed"

// Feast condition messages:
ReadyMessage = "FeatureStore installation complete"
Expand All @@ -62,6 +63,7 @@ const (
ClientReadyMessage = "Client installation complete"
CronJobReadyMessage = "CronJob installation complete"
KubernetesAuthzReadyMessage = "Kubernetes authorization installation complete"
OidcAuthzReadyMessage = "OIDC authorization installation complete"
DeploymentNotAvailableMessage = "Deployment is not available"

// entity_key_serialization_version
Expand Down
62 changes: 31 additions & 31 deletions infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2026-04-08T14:26:31Z"
createdAt: "2026-04-21T14:06:03Z"
operators.operatorframework.io/builder: operator-sdk-v1.38.0
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4
name: feast-operator.v0.62.0
Expand Down Expand Up @@ -79,9 +79,12 @@ spec:
clusterPermissions:
- rules:
- apiGroups:
- apps
- ""
resources:
- deployments
- configmaps
- persistentvolumeclaims
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -90,65 +93,62 @@ spec:
- update
- watch
- apiGroups:
- authentication.k8s.io
- ""
resources:
- tokenreviews
- namespaces
- pods
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- ""
resources:
- pods/exec
verbs:
- create
- apiGroups:
- autoscaling
- apps
resources:
- horizontalpodautoscalers
- deployments
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- batch
- authentication.k8s.io
resources:
- cronjobs
- tokenreviews
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
- autoscaling
resources:
- configmaps
- persistentvolumeclaims
- serviceaccounts
- services
- horizontalpodautoscalers
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
- batch
resources:
- namespaces
- pods
- secrets
- cronjobs
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- pods/exec
verbs:
- create
- apiGroups:
- feast.dev
resources:
Expand Down
Loading