-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: [Backend] Data Quality Monitoring with native compute, multi-backend support, REST API, CLI #6202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Backend] Data Quality Monitoring with native compute, multi-backend support, REST API, CLI #6202
Changes from 1 commit
d273343
65a6849
261c6e6
f32628d
e6fcd74
1f07b23
f1dbcb9
1a41858
707114e
50b45ac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Signed-off-by: Jitendra Yejare <11752425+jyejare@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,6 +94,22 @@ class MetricsConfig(FeastConfigBaseModel): | |
| identity, entity keys, feature views, row counts, and latency.""" | ||
|
|
||
|
|
||
| class DqmInitialDistributionConfig(FeastConfigBaseModel): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think these configs should also live at top instead of feature_server. It uses the offline store, not the online server. This field is more similar to This matches the pattern: materialization: spans offline+online stores, openlineage: spans apply+materialize - feature_monitoring: spans offline store (compute/storage) + apply trigger + server API.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be due to the existing metrics config is residing under server config. The metrics(even operational metrics) could also be computed for offline store. So I think its good if we move both operational metrics and dqm metrics under the parent monitoring config. |
||
| """Controls whether baseline distribution is computed on ``feast apply``.""" | ||
|
|
||
| enabled: StrictBool = True | ||
|
|
||
|
|
||
| class DqmDistributionConfig(FeastConfigBaseModel): | ||
| initial: DqmInitialDistributionConfig = DqmInitialDistributionConfig() | ||
|
|
||
|
|
||
| class DqmConfig(FeastConfigBaseModel): | ||
| """Data Quality Monitoring (DQM) configuration.""" | ||
|
|
||
| distribution: DqmDistributionConfig = DqmDistributionConfig() | ||
|
|
||
|
|
||
| class BaseFeatureServerConfig(FeastConfigBaseModel): | ||
| """Base Feature Server config that should be extended""" | ||
|
|
||
|
|
@@ -107,6 +123,9 @@ class BaseFeatureServerConfig(FeastConfigBaseModel): | |
| feature_logging: Optional[FeatureLoggingConfig] = None | ||
| """ Feature logging configuration """ | ||
|
|
||
| dqm: Optional[DqmConfig] = None | ||
| """Data Quality Monitoring configuration.""" | ||
|
|
||
| offline_push_batching_enabled: Optional[StrictBool] = None | ||
| """Whether to batch writes to the offline store via the `/push` endpoint.""" | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.