Rename mongodb_offline_store to mongodb, use One/Many naming convention

- Rename module: mongodb_offline_store/ → mongodb/ - Rename files: mongodb.py → mongodb_many.py, mongodb_native.py → mongodb_one.py Class renames: - MongoDBSource → MongoDBSourceMany - MongoDBOptions → MongoDBOptionsMany - SavedDatasetMongoDBStorage → SavedDatasetMongoDBStorageMany - MongoDBOfflineStoreIbis → MongoDBOfflineStoreMany - MongoDBOfflineStoreIbisConfig → MongoDBOfflineStoreManyConfig - MongoDBSourceNative → MongoDBSourceOne - MongoDBOfflineStoreNative → MongoDBOfflineStoreOne - MongoDBOfflineStoreNativeConfig → MongoDBOfflineStoreOneConfig - MongoDBNativeRetrievalJob → MongoDBOneRetrievalJob The One/Many naming reflects the core architectural difference: - One: Single shared collection for all FeatureViews - Many: One collection per FeatureView Signed-off-by: Casey Clements <casey.clements@mongodb.com>
feast-dev · ntkathole · Apr 30, 2026 · Mar 3, 2026 · Mar 4, 2026 · Mar 9, 2026
commit f273744fad69ca74464110bea574f4e52ecd9f72
diff --git a/...contrib/mongodb_offline_store/__init__.py → ...ffline_stores/contrib/mongodb/__init__.py b/...contrib/mongodb_offline_store/__init__.py → ...ffline_stores/contrib/mongodb/__init__.py
diff --git a/.../contrib/mongodb_offline_store/mongodb.py → ...ne_stores/contrib/mongodb/mongodb_many.py b/.../contrib/mongodb_offline_store/mongodb.py → ...ne_stores/contrib/mongodb/mongodb_many.py
@@ -34,7 +34,7 @@
     SavedDatasetLocationAlreadyExists,
 )
 from feast.feature_view import FeatureView
-from feast.infra.offline_stores.contrib.mongodb_offline_store import DRIVER_METADATA
+from feast.infra.offline_stores.contrib.mongodb import DRIVER_METADATA
 from feast.infra.offline_stores.ibis import (
     get_historical_features_ibis,
     pull_all_from_table_or_query_ibis,
@@ -86,11 +86,11 @@ def _infer_python_type_str(value: Any) -> Optional[str]:
 
 
 # ---------------------------------------------------------------------------
-# MongoDBSource and related classes (collection-per-FeatureView schema)
+# MongoDBSourceMany and related classes (one collection per FeatureView)
 # ---------------------------------------------------------------------------
 
 
-class MongoDBOptions:
+class MongoDBOptionsMany:
     """Options for a MongoDB data source (database + collection)."""
 
     def __init__(self, database: str, collection: str):
@@ -108,21 +108,21 @@ def to_proto(self) -> DataSourceProto.CustomSourceOptions:
     @classmethod
     def from_proto(
         cls, options_proto: DataSourceProto.CustomSourceOptions
-    ) -> "MongoDBOptions":
-        """Deserialize a CustomSourceOptions proto back into a MongoDBOptions instance."""
+    ) -> "MongoDBOptionsMany":
+        """Deserialize a CustomSourceOptions proto back into a MongoDBOptionsMany instance."""
         config = json.loads(options_proto.configuration.decode("utf8"))
         return cls(database=config["database"], collection=config["collection"])
 
 
-class MongoDBSource(DataSource):
-    """A MongoDB collection used as a Feast offline data source.
+class MongoDBSourceMany(DataSource):
+    """A MongoDB collection used as a Feast offline data source (one collection per FeatureView).
 
     ``name`` is the logical Feast name for this source. If omitted, it defaults
     to the value of ``collection``.  At least one of ``name`` or ``collection``
     must be supplied.
 
     ``database`` is the MongoDB database that contains the collection.  When
-    omitted it falls back to ``MongoDBOfflineStoreConfig.database`` at query
+    omitted it falls back to ``MongoDBOfflineStoreManyConfig.database`` at query
     time, so a single store-level default can be shared across many sources.
 
     ``schema_sample_size`` controls how many documents are randomly sampled
@@ -153,7 +153,7 @@ def __init__(
         # At least one of name / collection is non-None; cast to satisfy the type checker.
         name = cast(str, name or collection)
 
-        self._mongodb_options = MongoDBOptions(
+        self._mongodb_options = MongoDBOptionsMany(
             database=database or "",
             collection=collection or name,
         )
@@ -173,9 +173,9 @@ def __hash__(self):
         return super().__hash__()
 
     def __eq__(self, other):
-        if not isinstance(other, MongoDBSource):
+        if not isinstance(other, MongoDBSourceMany):
             raise TypeError(
-                "Comparisons should only involve MongoDBSource class objects."
+                "Comparisons should only involve MongoDBSourceMany class objects."
             )
         return (
             super().__eq__(other)
@@ -195,10 +195,10 @@ def collection(self) -> str:
         return self._mongodb_options._collection
 
     @staticmethod
-    def from_proto(data_source: DataSourceProto) -> "MongoDBSource":
+    def from_proto(data_source: DataSourceProto) -> "MongoDBSourceMany":
         assert data_source.HasField("custom_options")
         options = json.loads(data_source.custom_options.configuration)
-        return MongoDBSource(
+        return MongoDBSourceMany(
             name=data_source.name,
             database=options["database"],
             collection=options["collection"],
@@ -214,7 +214,7 @@ def _to_proto_impl(self) -> DataSourceProto:
         data_source_proto = DataSourceProto(
             name=self.name,
             type=DataSourceProto.CUSTOM_SOURCE,
-            data_source_class_type="feast.infra.offline_stores.contrib.mongodb_offline_store.mongodb.MongoDBSource",
+            data_source_class_type="feast.infra.offline_stores.contrib.mongodb.mongodb_many.MongoDBSourceMany",
             field_mapping=self.field_mapping,
             custom_options=self._mongodb_options.to_proto(),
             description=self.description,
@@ -281,25 +281,25 @@ def get_table_column_names_and_types(
         ]
 
 
-class SavedDatasetMongoDBStorage(SavedDatasetStorage):
-    """Persists a Feast SavedDataset into a MongoDB collection."""
+class SavedDatasetMongoDBStorageMany(SavedDatasetStorage):
+    """Persists a Feast SavedDataset into a MongoDB collection (many-collection schema)."""
 
     _proto_attr_name = "custom_storage"
 
-    mongodb_options: MongoDBOptions
+    mongodb_options: MongoDBOptionsMany
 
     def __init__(self, database: str, collection: str):
-        self.mongodb_options = MongoDBOptions(
+        self.mongodb_options = MongoDBOptionsMany(
             database=database,
             collection=collection,
         )
 
     @staticmethod
     def from_proto(
         storage_proto: SavedDatasetStorageProto,
-    ) -> "SavedDatasetMongoDBStorage":
+    ) -> "SavedDatasetMongoDBStorageMany":
         options = json.loads(storage_proto.custom_storage.configuration)
-        return SavedDatasetMongoDBStorage(
+        return SavedDatasetMongoDBStorageMany(
             database=options["database"],
             collection=options["collection"],
         )
@@ -308,7 +308,7 @@ def to_proto(self) -> SavedDatasetStorageProto:
         return SavedDatasetStorageProto(custom_storage=self.mongodb_options.to_proto())
 
     def to_data_source(self) -> DataSource:
-        return MongoDBSource(
+        return MongoDBSourceMany(
             database=self.mongodb_options._database,
             collection=self.mongodb_options._collection,
         )
@@ -319,10 +319,10 @@ def to_data_source(self) -> DataSource:
 # ---------------------------------------------------------------------------
 
 
-class MongoDBOfflineStoreIbisConfig(FeastConfigBaseModel):
-    """Configuration for the MongoDB Ibis-backed offline store."""
+class MongoDBOfflineStoreManyConfig(FeastConfigBaseModel):
+    """Configuration for the MongoDB offline store (one collection per FeatureView)."""
 
-    type: StrictStr = "feast.infra.offline_stores.contrib.mongodb_offline_store.mongodb.MongoDBOfflineStoreIbis"
+    type: StrictStr = "feast.infra.offline_stores.contrib.mongodb.mongodb_many.MongoDBOfflineStoreMany"
     """Offline store type selector"""
 
     connection_string: StrictStr = "mongodb://localhost:27017"
@@ -332,8 +332,12 @@ class MongoDBOfflineStoreIbisConfig(FeastConfigBaseModel):
     """Default MongoDB database name"""
 
 
-class MongoDBOfflineStoreIbis(OfflineStore):
-    """Offline store backed by MongoDB, using Ibis for point-in-time joins."""
+class MongoDBOfflineStoreMany(OfflineStore):
+    """Offline store backed by MongoDB (one collection per FeatureView).
+
+    Uses Ibis memtables for point-in-time joins. Each FeatureView's data is stored
+    in a separate MongoDB collection, with the collection name matching the source name.
+    """
 
     @staticmethod
     def pull_latest_from_table_or_query(
@@ -346,9 +350,9 @@ def pull_latest_from_table_or_query(
         start_date: datetime,
         end_date: datetime,
     ) -> RetrievalJob:
-        if not isinstance(data_source, MongoDBSource):
+        if not isinstance(data_source, MongoDBSourceMany):
             raise ValueError(
-                f"MongoDBOfflineStore expected a MongoDBSource, "
+                f"MongoDBOfflineStoreMany expected a MongoDBSourceMany, "
                 f"got {type(data_source).__name__!r}."
             )
         warnings.warn(
@@ -405,9 +409,9 @@ def pull_all_from_table_or_query(
         start_date: Optional[datetime] = None,
         end_date: Optional[datetime] = None,
     ) -> RetrievalJob:
-        if not isinstance(data_source, MongoDBSource):
+        if not isinstance(data_source, MongoDBSourceMany):
             raise ValueError(
-                f"MongoDBOfflineStore expected a MongoDBSource, "
+                f"MongoDBOfflineStoreMany expected a MongoDBSourceMany, "
                 f"got {type(data_source).__name__!r}."
             )
         warnings.warn(
@@ -436,9 +440,9 @@ def reader(data_source: DataSource, repo_path: str) -> Table:
             raise FeastExtrasDependencyImportError(
                 "mongodb", "pymongo is not installed."
             )
-        if not isinstance(data_source, MongoDBSource):
+        if not isinstance(data_source, MongoDBSourceMany):
             raise ValueError(
-                f"MongoDBOfflineStore reader expected a MongoDBSource, "
+                f"MongoDBOfflineStoreMany reader expected a MongoDBSourceMany, "
                 f"got {type(data_source).__name__!r}."
             )
         connection_string = config.offline_store.connection_string
@@ -487,9 +491,9 @@ def writer(
             raise FeastExtrasDependencyImportError(
                 "mongodb", "pymongo is not installed."
             )
-        if not isinstance(data_source, MongoDBSource):
+        if not isinstance(data_source, MongoDBSourceMany):
             raise ValueError(
-                f"MongoDBOfflineStore writer expected a MongoDBSource, "
+                f"MongoDBOfflineStoreMany writer expected a MongoDBSourceMany, "
                 f"got {type(data_source).__name__!r}."
             )
         connection_string = config.offline_store.connection_string

diff --git a/...b/mongodb_offline_store/mongodb_native.py → ...ine_stores/contrib/mongodb/mongodb_one.py b/...b/mongodb_offline_store/mongodb_native.py → ...ine_stores/contrib/mongodb/mongodb_one.py
@@ -109,7 +109,7 @@
 from feast.errors import DataSourceNoNameException, FeastExtrasDependencyImportError
 from feast.feature_view import FeatureView
 from feast.infra.key_encoding_utils import serialize_entity_key
-from feast.infra.offline_stores.contrib.mongodb_offline_store import DRIVER_METADATA
+from feast.infra.offline_stores.contrib.mongodb import DRIVER_METADATA
 from feast.infra.offline_stores.offline_store import (
     OfflineStore,
     RetrievalJob,
@@ -127,10 +127,12 @@
 from feast.value_type import ValueType
 
 
-class MongoDBOfflineStoreNativeConfig(FeastConfigBaseModel):
-    """Configuration for the Native MongoDB offline store."""
+class MongoDBOfflineStoreOneConfig(FeastConfigBaseModel):
+    """Configuration for the MongoDB offline store (single shared collection)."""
 
-    type: StrictStr = "feast.infra.offline_stores.contrib.mongodb_offline_store.mongodb_native.MongoDBOfflineStoreNative"
+    type: StrictStr = (
+        "feast.infra.offline_stores.contrib.mongodb.mongodb_one.MongoDBOfflineStoreOne"
+    )
     """Offline store type selector"""
 
     connection_string: StrictStr = "mongodb://localhost:27017"
@@ -143,12 +145,12 @@ class MongoDBOfflineStoreNativeConfig(FeastConfigBaseModel):
     """Single collection name for all feature views"""
 
 
-class MongoDBSourceNative(DataSource):
-    """A MongoDB data source for the native offline store.
+class MongoDBSourceOne(DataSource):
+    """A MongoDB data source for the single-collection offline store.
 
-    Unlike many data source implementations, this source does not map each
-    FeatureView to its own table or collection. Instead, all FeatureViews
-    share a single MongoDB collection (configured at the store level).
+    Unlike MongoDBSourceMany, this source does not map each FeatureView to
+    its own collection. Instead, all FeatureViews share a single MongoDB
+    collection (configured at the store level).
 
     Each document in that collection includes a ``feature_view`` field that
     identifies which FeatureView it belongs to. The ``name`` of this data
@@ -183,9 +185,9 @@ def __hash__(self):
         return super().__hash__()
 
     def __eq__(self, other):
-        if not isinstance(other, MongoDBSourceNative):
+        if not isinstance(other, MongoDBSourceOne):
             raise TypeError(
-                "Comparisons should only involve MongoDBSourceNative class objects."
+                "Comparisons should only involve MongoDBSourceOne class objects."
             )
         return (
             super().__eq__(other)
@@ -203,9 +205,9 @@ def source_type(self) -> DataSourceProto.SourceType.ValueType:
         return DataSourceProto.CUSTOM_SOURCE
 
     @staticmethod
-    def from_proto(data_source: DataSourceProto) -> "MongoDBSourceNative":
+    def from_proto(data_source: DataSourceProto) -> "MongoDBSourceOne":
         assert data_source.HasField("custom_options")
-        return MongoDBSourceNative(
+        return MongoDBSourceOne(
             name=data_source.name,
             timestamp_field=data_source.timestamp_field,
             created_timestamp_column=data_source.created_timestamp_column,
@@ -219,7 +221,7 @@ def _to_proto_impl(self) -> DataSourceProto:
         return DataSourceProto(
             name=self.name,
             type=DataSourceProto.CUSTOM_SOURCE,
-            data_source_class_type="feast.infra.offline_stores.contrib.mongodb_offline_store.mongodb_native.MongoDBSourceNative",
+            data_source_class_type="feast.infra.offline_stores.contrib.mongodb_offline_store.mongodb_native.MongoDBSourceOne",
             field_mapping=self.field_mapping,
             custom_options=DataSourceProto.CustomSourceOptions(
                 configuration=json.dumps({"feature_view": self.name}).encode()
@@ -320,7 +322,7 @@ def _fetch_documents(
     return list(client[database][collection].aggregate(pipeline))
 
 
-class MongoDBNativeRetrievalJob(RetrievalJob):
+class MongoDBOneRetrievalJob(RetrievalJob):
     """Retrieval job for native MongoDB offline store queries."""
 
     def __init__(
@@ -384,7 +386,7 @@ def _serialize_entity_key_from_row(
     return serialize_entity_key(entity_key, entity_key_serialization_version)
 
 
-class MongoDBOfflineStoreNative(OfflineStore):
+class MongoDBOfflineStoreOne(OfflineStore):
     """Native MongoDB offline store using single-collection schema.
 
     All feature views share one collection (``feature_history``), with documents
@@ -452,9 +454,9 @@ def pull_latest_from_table_or_query(
         start_date: datetime,
         end_date: datetime,
     ) -> RetrievalJob:
-        if not isinstance(data_source, MongoDBSourceNative):
+        if not isinstance(data_source, MongoDBSourceOne):
             raise ValueError(
-                f"MongoDBOfflineStoreNative expected MongoDBSourceNative, "
+                f"MongoDBOfflineStoreOne expected MongoDBSourceOne, "
                 f"got {type(data_source).__name__!r}."
             )
         warnings.warn(
@@ -499,7 +501,7 @@ def pull_latest_from_table_or_query(
         ]
 
         def _run() -> pyarrow.Table:
-            client = MongoDBOfflineStoreNative._get_client_and_ensure_indexes(config)
+            client = MongoDBOfflineStoreOne._get_client_and_ensure_indexes(config)
             try:
                 docs = _fetch_documents(client, db_name, collection, pipeline)
                 if not docs:
@@ -515,7 +517,7 @@ def _run() -> pyarrow.Table:
             finally:
                 client.close()
 
-        return MongoDBNativeRetrievalJob(query_fn=_run, full_feature_names=False)
+        return MongoDBOneRetrievalJob(query_fn=_run, full_feature_names=False)
 
     @staticmethod
     def pull_all_from_table_or_query(
@@ -528,9 +530,9 @@ def pull_all_from_table_or_query(
         start_date: Optional[datetime] = None,
         end_date: Optional[datetime] = None,
     ) -> RetrievalJob:
-        if not isinstance(data_source, MongoDBSourceNative):
+        if not isinstance(data_source, MongoDBSourceOne):
             raise ValueError(
-                f"MongoDBOfflineStoreNative expected MongoDBSourceNative, "
+                f"MongoDBOfflineStoreOne expected MongoDBSourceOne, "
                 f"got {type(data_source).__name__!r}."
             )
         warnings.warn(
@@ -571,7 +573,7 @@ def pull_all_from_table_or_query(
         ]
 
         def _run() -> pyarrow.Table:
-            client = MongoDBOfflineStoreNative._get_client_and_ensure_indexes(config)
+            client = MongoDBOfflineStoreOne._get_client_and_ensure_indexes(config)
             try:
                 docs = _fetch_documents(client, db_name, collection, pipeline)
                 if not docs:
@@ -587,7 +589,7 @@ def _run() -> pyarrow.Table:
             finally:
                 client.close()
 
-        return MongoDBNativeRetrievalJob(query_fn=_run, full_feature_names=False)
+        return MongoDBOneRetrievalJob(query_fn=_run, full_feature_names=False)
 
     @staticmethod
     def get_historical_features(
@@ -610,7 +612,7 @@ def get_historical_features(
         """
         if isinstance(entity_df, str):
             raise ValueError(
-                "MongoDBOfflineStoreNative does not support SQL entity_df strings. "
+                "MongoDBOfflineStoreOne does not support SQL entity_df strings. "
                 "Pass a pandas DataFrame instead."
             )
         warnings.warn(
@@ -777,7 +779,7 @@ def _run() -> pyarrow.Table:
             working_df["_row_idx"] = range(len(working_df))
 
             # Create client once for all chunks
-            client = MongoDBOfflineStoreNative._get_client_and_ensure_indexes(config)
+            client = MongoDBOfflineStoreOne._get_client_and_ensure_indexes(config)
             try:
                 coll = client[db_name][feature_collection]
 
@@ -807,7 +809,7 @@ def _run() -> pyarrow.Table:
 
             return pyarrow.Table.from_pandas(result_df, preserve_index=False)
 
-        return MongoDBNativeRetrievalJob(
+        return MongoDBOneRetrievalJob(
             query_fn=_run,
             full_feature_names=full_feature_names,
         )