fix: Address second round of PR review feedback from Devin

- Fix current_version_number roundtrip bug: version="latest" (always truthy) caused None to become 0 after proto roundtrip; now check that spec.version is not "latest" before treating 0 as intentional - Use write_engine (not read_engine) for pre/post apply reads in SqlRegistry to avoid read replica lag causing missed version snapshots - Remove redundant version check in StreamFeatureView.__eq__ (parent FeatureView.__eq__ already checks it) - Add else clause to StreamFeatureView.from_proto for consistency - Add test for latest/None roundtrip preservation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feast-dev · franciscojavierarceo · Mar 26, 2026 · Mar 12, 2026 · Mar 12, 2026 · Mar 13, 2026
commit f035e96d45b8b0b276ec64c8f11c3e03a2c06df5
@@ -644,14 +644,16 @@ def _from_proto_internal(
         # Restore version fields.
         feature_view.version = feature_view_proto.spec.version or "latest"
         # proto3 int32 defaults to 0, so use spec.version to distinguish
-        # "actually version 0" from "no version set"
+        # "actually version 0" from "no version set". A version of "latest"
+        # (or empty) with current_version_number==0 means "not versioned yet".
         if feature_view_proto.meta.current_version_number:
             feature_view.current_version_number = (
                 feature_view_proto.meta.current_version_number
             )
         elif (
             feature_view_proto.meta.current_version_number == 0
             and feature_view_proto.spec.version
+            and feature_view_proto.spec.version.lower() != "latest"
         ):
             feature_view.current_version_number = 0
         else:

@@ -637,9 +637,10 @@ def apply_feature_view(
             )
 
         # Normal (latest) apply: snapshot old version if changed, then save new
-        # First check if the FV already exists so we can snapshot the old one
+        # First check if the FV already exists so we can snapshot the old one.
+        # Use write_engine for both reads to avoid read replica lag issues.
         old_proto_bytes = None
-        with self.read_engine.begin() as conn:
+        with self.write_engine.begin() as conn:
             stmt = select(fv_table).where(
                 fv_table.c.feature_view_name == feature_view.name,
                 fv_table.c.project_id == project,
@@ -656,7 +657,7 @@ def apply_feature_view(
         )
 
         # After apply, read the current proto to see if it changed
-        with self.read_engine.begin() as conn:
+        with self.write_engine.begin() as conn:
             stmt = select(fv_table).where(
                 fv_table.c.feature_view_name == feature_view.name,
                 fv_table.c.project_id == project,

@@ -564,6 +564,7 @@ def from_proto(
         elif (
             on_demand_feature_view_proto.meta.current_version_number == 0
             and on_demand_feature_view_proto.spec.version
+            and on_demand_feature_view_proto.spec.version.lower() != "latest"
         ):
             on_demand_feature_view_obj.current_version_number = 0
         else:

@@ -35,7 +35,6 @@
 )
 from feast.transformation.base import Transformation
 from feast.transformation.mode import TransformationMode
-from feast.version_utils import normalize_version_string
 
 warnings.simplefilter("once", RuntimeWarning)
 
@@ -227,8 +226,6 @@ def __eq__(self, other):
             or self.udf.__code__.co_code != other.udf.__code__.co_code
             or self.udf_string != other.udf_string
             or self.aggregations != other.aggregations
-            or normalize_version_string(self.version)
-            != normalize_version_string(other.version)
         ):
             return False
 
@@ -364,8 +361,14 @@ def from_proto(cls, sfv_proto):
             stream_feature_view.current_version_number = (
                 sfv_proto.meta.current_version_number
             )
-        elif sfv_proto.meta.current_version_number == 0 and sfv_proto.spec.version:
+        elif (
+            sfv_proto.meta.current_version_number == 0
+            and sfv_proto.spec.version
+            and sfv_proto.spec.version.lower() != "latest"
+        ):
             stream_feature_view.current_version_number = 0
+        else:
+            stream_feature_view.current_version_number = None
 
         stream_feature_view.entities = list(sfv_proto.spec.entities)
 

@@ -174,6 +174,27 @@ def test_feature_view_proto_roundtrip_v0(self):
         assert fv2.version == "v0"
         assert fv2.current_version_number == 0
 
+    def test_feature_view_proto_roundtrip_latest_none(self):
+        """version='latest' with current_version_number=None must not become 0."""
+        from datetime import timedelta
+
+        from feast.entity import Entity
+        from feast.feature_view import FeatureView
+
+        entity = Entity(name="entity_id", join_keys=["entity_id"])
+        fv = FeatureView(
+            name="test_fv",
+            entities=[entity],
+            ttl=timedelta(days=1),
+            # default version="latest", current_version_number=None
+        )
+        assert fv.current_version_number is None
+
+        proto = fv.to_proto()
+        fv2 = FeatureView.from_proto(proto)
+        assert fv2.version == "latest"
+        assert fv2.current_version_number is None
+
     def test_feature_view_equality_with_version(self):
         from datetime import timedelta