Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Address review feedback
Signed-off-by: soojin <soojin@dable.io>
  • Loading branch information
soooojinlee authored and ntkathole committed Apr 1, 2026
commit 6c9ba6355745811523a023e26aa43aefa4269675
6 changes: 4 additions & 2 deletions sdk/python/feast/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,10 @@ class Set(ComplexFeastType):
base_type: Union[PrimitiveFeastType, ComplexFeastType]

def __init__(self, base_type: Union[PrimitiveFeastType, ComplexFeastType]):
# Sets do not support MAP as a base type
supported_set_types = [t for t in SUPPORTED_BASE_TYPES if t != Map]
# Sets do not support MAP, UUID, or TimeUuid as base types
supported_set_types = [
t for t in SUPPORTED_BASE_TYPES if t not in (Map, Uuid, TimeUuid)
]
if base_type not in supported_set_types:
raise ValueError(
f"Type {type(base_type)} is currently not supported as a base type for Set."
Expand Down