Skip to content

fix: Add possibility to overwrite send_receive_timeout for clickhouse offline store #5792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 4 commits into from
Dec 23, 2025
Merged

fix: Add possibility to overwrite send_receive_timeout for clickhouse offline store #5792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f5a1c1
add changes + fix linting issues
astronautas Dec 22, 2025
24f6f40
generalize based on pr suggestion
astronautas Dec 22, 2025
a05c6ab
add test verifying config parsing
astronautas Dec 22, 2025
a3b9977
rework test into integration, since CH instance is needed
astronautas Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
generalize based on pr suggestion 
Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>
  • Loading branch information
@astronautas @ntkathole
astronautas authored and ntkathole committed Dec 23, 2025
commit 24f6f40fc8f65f10360603eef7e015c85196f4fa
7 changes: 5 additions & 2 deletions sdk/python/feast/infra/utils/clickhouse/clickhouse_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from typing import Any

from pydantic import ConfigDict, StrictStr

from feast.repo_config import FeastConfigBaseModel
Expand All @@ -11,7 +13,8 @@ class ClickhouseConfig(FeastConfigBaseModel):
password: StrictStr
use_temporary_tables_for_entity_df: bool = True

# Set this to higher than default, for larger scale offline store jobs
send_receive_timeout: int | None = None
# See https://github.com/ClickHouse/clickhouse-connect/blob/main/clickhouse_connect/driver/__init__.py#L51
# Some typical ones e.g. send_receive_timeout (read_timeout), etc
additional_client_args: dict[str, Any] | None = None

model_config = ConfigDict(frozen=True)
6 changes: 4 additions & 2 deletions sdk/python/feast/infra/utils/clickhouse/connection_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@
def get_client(config: ClickhouseConfig) -> Client:
# Clickhouse client is not thread-safe, so we need to create a separate instance for each thread.
if not hasattr(thread_local, "clickhouse_client"):
if config.send_receive_timeout is not None:
additional_client_args = config.additional_client_args

if additional_client_args:
thread_local.clickhouse_client = clickhouse_connect.get_client(
host=config.host,
port=config.port,
user=config.user,
password=config.password,
database=config.database,
send_receive_timeout=config.send_receive_timeout,
**additional_client_args,
)
else:
thread_local.clickhouse_client = clickhouse_connect.get_client(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/infra/offline_stores/test_clickhouse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_get_client_with_additional_params(clickhouse_container):
user="default",
password="password",
database="default",
send_receive_timeout=60,
additional_client_args={"send_receive_timeout": 60},
)

# Get client and verify it works
Expand Down