Skip to content

feat: Feature View Field powered to define Vector length instead of Config #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 10 commits into from
Apr 23, 2025
Merged

feat: Feature View Field powered to define Vector length instead of Config #5289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6038aac
No vector length - Postgress
jyejare Apr 16, 2025
93cb9f5
Field of Vector length
jyejare Apr 16, 2025
1c65906
SQLite vector length
jyejare Apr 21, 2025
bdcc759
ElasticSearch vector length
jyejare Apr 21, 2025
f4118dc
Qdrant Vector length
jyejare Apr 21, 2025
df15f5a
Test vector_length updates and related Fixes
jyejare Apr 21, 2025
1e7ef9a
Vector length cleanup for Store confgis
jyejare Apr 22, 2025
48e4184
All Protos regenerated
jyejare Apr 22, 2025
b4742f6
Vector len param renamed to Vector length
jyejare Apr 23, 2025
b431074
On Demand feature view transformation updated
jyejare Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ElasticSearch vector length 
Signed-off-by: jyejare <jyejare@redhat.com>
  • Loading branch information
@jyejare
jyejare committed Apr 21, 2025
commit bdcc7594b26f1234bb782b9c415561b6395edccc
2 changes: 1 addition & 1 deletion docs/reference/online-stores/elasticsearch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Currently, the indexing mapping in the ElasticSearch online store is configured
"created_ts": {"type": "date"},
"vector_value": {
"type": "dense_vector",
"dims": config.online_store.vector_len,
"dims": vector_field_length,
"index": "true",
"similarity": config.online_store.similarity,
},
Expand Down
6 changes: 4 additions & 2 deletions sdk/python/feast/infra/online_stores/elasticsearch_online_store/elasticsearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
from feast.protos.feast.types.Value_pb2 import Value as ValueProto
from feast.repo_config import FeastConfigBaseModel
from feast.utils import _build_retrieve_online_document_record, to_naive_utc
from feast.utils import _build_retrieve_online_document_record, to_naive_utc, _get_feature_view_vector_field_metadata


class ElasticSearchOnlineStoreConfig(FeastConfigBaseModel, VectorStoreConfig):
Expand Down Expand Up @@ -161,6 +161,8 @@ def create_index(self, config: RepoConfig, table: FeatureView):
config: Feast repo configuration object.
table: FeatureView table for which the index needs to be created.
"""
vector_field_length = _get_feature_view_vector_field_metadata(table).vector_len or 512

index_mapping = {
"properties": {
"entity_key": {"type": "binary"},
Expand All @@ -170,7 +172,7 @@ def create_index(self, config: RepoConfig, table: FeatureView):
"created_ts": {"type": "date"},
"vector_value": {
"type": "dense_vector",
"dims": config.online_store.vector_len,
"dims": vector_field_length,
"index": "true",
"similarity": config.online_store.similarity,
},
Expand Down