Skip to content

fix: Update actions to remove check skip tests #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Apr 16, 2025
Merged

fix: Update actions to remove check skip tests #5275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Update actions to remove check skip tests 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Apr 16, 2025
commit 74de8edf913d91c81d9c7a2fcfa42a19d8ac022c
12 changes: 3 additions & 9 deletions .github/workflows/java_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,12 @@ permissions:
pull-requests: read

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

lint-java:
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.repository == 'feast-dev/feast'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -41,7 +35,7 @@ jobs:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.repository == 'feast-dev/feast'
runs-on: ubuntu-latest
needs: lint-java
steps:
Expand Down Expand Up @@ -119,7 +113,7 @@ jobs:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.repository == 'feast-dev/feast'
runs-on: ubuntu-latest
needs: unit-test-java
env:
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/operator-e2e-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,12 @@ on:
- 'infra/**'

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

operator-e2e-tests:
timeout-minutes: 40
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.repository == 'feast-dev/feast'
runs-on: ubuntu-latest

services:
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/operator_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,7 @@ name: operator-pr

on: [pull_request]
jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

operator-test:
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,12 @@ permissions:
pull-requests: read

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

integration-test-python:
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.repository == 'feast-dev/feast'
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/pr_local_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,11 @@ on:
- labeled

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

integration-test-python-local:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/pr_remote_rbac_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,11 @@ on:
- labeled

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

remote-rbac-integration-tests-python:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/smoke_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,7 @@ on:
pull_request:

jobs:
check_skip_tests:
uses: ./.github/workflows/check_skip_tests.yml
with:
head-sha: ${{ github.event.pull_request.head.sha }}
excluded-dirs: 'docs/**,tests/**,examples/**'

unit-test-python:
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
smoke-test-python:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,7 @@ on:
pull_request:

jobs:
check_skip_tests:
runs-on: ubuntu-latest
outputs:
skip_tests: ${{ steps.check.outputs.skip_tests }}
steps:
- uses: actions/checkout@v4
- id: check
uses: ./.github/actions/check-skip-tests
with:
head-sha: ${{ github.event.pull_request.head.sha || github.sha }}

unit-test-python:
needs: [check_skip_tests]
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -55,7 +42,6 @@ jobs:
run: uv cache prune --ci

unit-test-ui:
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
runs-on: ubuntu-latest
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down