Randomized string concat - #216
Conversation
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
Co-authored-by: Juan Vásquez <javasgon@gmail.com>
|
Thnx @JuanVqz, no worries for the delay :). I've commited suggested! |
|
@mateusdeap could you please have a look to merge it? |
@etagwerker Hi Ernesto! Sorry for the delayed answer. The problem is it will not look as good as we migh expect, because of a randomization )). It will show a much bigger variance (20-30-40% I can't recall properly) over relatively "small" difference. I might give it a try one more time, but can't promise that it will be soon enough :(. I need an inspiration to dive in to that river again ))). |
|
Can we also add: [foo, bar].joinIt would also make sense to check if there will be different results with more than 2 strings to concatenate. Also, would be nice to see performance comparison of cases like: "#{foo}-#{bar}" |
etagwerker
left a comment
There was a problem hiding this comment.
@alekseyl Looks good, thank you!
proposition for #158 fix.