Conversation
…s 'key' when generating a hash
dhavalsingh
approved these changes
Jan 10, 2022
Contributor
Author
|
Thank you. :) That's a blast from the past |
Member
|
Thank you for this contribution! It landed in #247, with you credited as co-author on its commit. The 1000-pair benchmark is split into building and reading files with fixed data, and the one-pair literal file was left out, since on current Ruby each of those literals compiles to a copy of a prebuilt Hash. Closing this in favor of #247. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a benchmark to show that for larger hash the difference in using :key vs 'key' for hashes could be significant, especially using latest versions of Ruby ( 2.4.2)
Juanito let me know what you think. If you like this benchmark - I have a couple more ideas. Thanks