Skip to content

Allow use of add_*_selector methods in ScatterGraphic #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lkeegan wants to merge 18 commits into from
Closed

Allow use of add_*_selector methods in ScatterGraphic #883

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
acab9d0
Allow use of `add_*_selector` methods in `ScatterGraphic`
lkeegan Jul 21, 2025
5ae771e
Update linear/rectangle selectors to work with ScatterGraphics, add e…
lkeegan Jul 22, 2025
c5ec080
refactor bounds_init logic to make intent clearer, add comment, remov…
lkeegan Jul 23, 2025
75b7d73
restore y-padding on rectangle selector limits, refactored to also wo…
lkeegan Jul 23, 2025
c28163f
Merge branch 'main' into scatter_graphic_add_linear_selector
lkeegan Sep 29, 2025
e2d6b9f
Add `add_polygon_selector` method to `ScatterGraphic` and create an e…
lkeegan Sep 30, 2025
8776b29
allow selection to extend by 25% padding in all directions
lkeegan Oct 1, 2025
7898ad2
enable ground truth screenshots for scatter selector examples
lkeegan Oct 1, 2025
82870b9
set initial polygon selection in example and reset _move_info after s…
lkeegan Oct 1, 2025
9054ae0
Merge branch 'main' into scatter_graphic_add_linear_selector
lkeegan Nov 10, 2025
2b607b5
Update fastplotlib/graphics/selectors/_polygon.py
lkeegan Jan 30, 2026
5313a05
Update fastplotlib/graphics/selectors/_rectangle.py
lkeegan Jan 30, 2026
481138b
Update fastplotlib/graphics/selectors/_polygon.py
lkeegan Jan 30, 2026
41c3a02
run black on examples/selection_tools/linear_region_scatter.py
lkeegan Jan 30, 2026
4db8d34
Merge branch 'main' into scatter_graphic_add_linear_selector
lkeegan Jan 30, 2026
6e5b923
update add_*_selector to match main branch (keeping previous changes …
lkeegan Jan 30, 2026
4598ae0
fix typos
lkeegan Jan 30, 2026
b0720b4
Add sizes to linear region scatter example
lkeegan Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
allow selection to extend by 25% padding in all directions
  • Loading branch information
@lkeegan
lkeegan committed Oct 1, 2025
commit 8776b2966b499007ecfc8a777b908c6b60cda1f9
5 changes: 3 additions & 2 deletions fastplotlib/graphics/scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,10 @@ def add_polygon_selector(
y25p = 0.25 * (ymax - ymin)
xmin = np.floor(x_axis_vals.min()).astype(int)
xmax = np.ceil(x_axis_vals.max()).astype(int)
x25p = 0.25 * (xmax - xmin)

# min/max limits include the data + 25% padding in the y-direction
limits = (xmin, xmax, ymin - y25p, ymax + y25p)
# min/max limits include the data + 25% padding in both directions
limits = (xmin - x25p, xmax + x25p, ymin - y25p, ymax + y25p)

selector = PolygonSelector(
selection,
Expand Down