-
Notifications
You must be signed in to change notification settings - Fork 66
Graphic features refactor #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
197 commits
Select commit
Hold shift + click to select a range
60e7f60
just a start
kushalkolar 6eec7d5
pushing to continue on my desktop
kushalkolar 0249125
progress on buffer manager cleanup_key
kushalkolar 9d891ee
more progress, still lots to do
kushalkolar 9635bc0
slicing working with PointsDataFeature, negative slices too, still ma…
kushalkolar 9be017c
comitting stuff
kushalkolar 0491f8c
_update_range() is pretty good now
kushalkolar 97b7303
comment
kushalkolar 4585be2
if statement
kushalkolar 261a5a9
simply colors setting
kushalkolar 5d40af8
type annotation
kushalkolar 697d50e
simpler slice parsing
kushalkolar 08fd17d
remove cleanup_key :D :D :D git status!
kushalkolar a45651d
all fancy and negative indexing working :D
kushalkolar 9612d60
start tests
kushalkolar dda8396
exception message
kushalkolar e22fe7c
more on tests
kushalkolar 9b4082f
refactor sizes, not tested yet
kushalkolar 2a1869c
start parameterizing buffer tests
kushalkolar 29a0a76
better buffer tests
kushalkolar 054c836
more variants
kushalkolar f50614f
add array fancy indexing to same parameterization
kushalkolar 9ed2bf6
parameterize tuple tests
kushalkolar 5e1471e
remove repr
kushalkolar f59fb19
test offset and size
kushalkolar 4d25daa
test offset and size
kushalkolar aa1949b
test create colors
kushalkolar c74d7b9
also test with direct truth indices in colors
kushalkolar cecb438
points tests, works
kushalkolar 0a20008
remove imports
kushalkolar a1c8c87
sizes test working, other cleanup
kushalkolar db93f70
export sizes feature again
kushalkolar baca1fc
ideas for sharing and unsharing buffers between graphics
kushalkolar a177a7f
ideas for sharing and unsharing buffers between graphics, nto tested
kushalkolar c205b10
typing
kushalkolar f380b26
attach and detach buffers to a graphic, not tested
kushalkolar 3585c9e
import
kushalkolar 8d32134
more int point tests
kushalkolar deceeeb
Graphic.add_event_handler
kushalkolar 66b5e6d
adding and removing data feature event works and tested
kushalkolar 3a58feb
common features, WIP
kushalkolar adcc13f
regular features and refactor line and scatter into positions graphic
kushalkolar 762fcbb
uniform sizes
kushalkolar 3017b7e
implement sizes and uniform size for scatter
kushalkolar a45b3f9
VertexCmap feature, not yet tested
kushalkolar 09ce4f5
start image features, not tested, add thickness, not tested
kushalkolar 93e7a9d
better cmap parsing
kushalkolar 2be22f6
cleanup
kushalkolar eedee8f
image features
kushalkolar 67ad327
cleanup
kushalkolar b417190
start selection feature refactor
kushalkolar eb47408
more on selection features
kushalkolar ab80033
offset and rotation for base graphic
kushalkolar da433de
feature event table
kushalkolar d12d4fa
position feature event tables
kushalkolar 570683a
rotation and offset features
kushalkolar ec6b2f4
work on selectors, WIP, linear region selector inits properly and mov…
kushalkolar db910d3
proper centering
kushalkolar a09386b
much simpliified and better linear region selector
kushalkolar 49c2108
linear region selector works well on x axis with events and data sele…
kushalkolar 1ec0f40
vertex cmap fix, delete synchronizer
kushalkolar 5022753
linear selector works
kushalkolar f295356
cleanup
kushalkolar 4d4d636
update graphic methods mixin
kushalkolar 1d6adc6
update selector example nbs, still WIP
kushalkolar 284a1db
type annotation in setter
kushalkolar b4fe957
add notes to tests comments
kushalkolar e6b9133
refactor image stuff
kushalkolar 820772d
image selector tool
kushalkolar 254f0ba
return selectors as proxies
kushalkolar 2bf33fa
image stuff works
kushalkolar 67404ca
fix offsets adding graphics, fix positions_graphic cmap bug, quicksta…
kushalkolar b1b297d
fix add_graphic args and mixin
kushalkolar 74f8428
simpler graphic collection stuff
kushalkolar 6eb5a1a
more line collection
kushalkolar f543e4a
remove old events system
clewis7 aa1e974
fix some examples
clewis7 aa324df
remove lingering older interaction stuff
kushalkolar 00ba47f
cleanup
kushalkolar 233dab7
fill color arg
kushalkolar 4da827c
black
kushalkolar d785b92
update examples
clewis7 3a424d2
fix image tiling, better heatmap example
kushalkolar 9157048
Merge branch 'graphic-features-refactor' of https://github.com/fastpl…
kushalkolar 87c8d9d
update hm examples
kushalkolar d99a94b
fix hlut
clewis7 fb1dde6
refactor graphics base
kushalkolar 428aab0
update line examples
kushalkolar a41432f
bug fixes
kushalkolar 0eb6ad4
update text to use new gfeatures
kushalkolar 739b47a
cleanup
kushalkolar ce8082d
implement iterator for TextureArray, much simpler now :D
kushalkolar f141d23
basic texture tests
kushalkolar 1f76224
bugfix, cleanup
kushalkolar 273962f
image graphic tests
kushalkolar 61db941
type annot
kushalkolar aafa452
test stuff
kushalkolar fa4b2ac
tests for common and visible kwarg for Graphic
kushalkolar 2c6843b
bugfix
kushalkolar 9ca2c2a
test remove event hanlders common fea
kushalkolar 72824eb
rename
kushalkolar 105cd86
start test positions graphics
kushalkolar feabe7a
test progress
kushalkolar c82b90c
black
kushalkolar 2810578
add __len__ to buffer managers, add __array_interface__ raises error
kushalkolar 4d07e4f
TextureArray has len()
kushalkolar 84c0be9
docstring
kushalkolar ed686dd
updates and tests
kushalkolar 8d57c50
black
kushalkolar f01811a
uniform colors tests and bug fix
kushalkolar 59b5550
black
kushalkolar cd40638
bugfix uniform color and sizes
kushalkolar 10ba958
sizes and thickness tests
kushalkolar e99010e
tests update
kushalkolar 3acabe3
lotta team work
clewis7 072fd91
docstring, small things
kushalkolar 2972e84
rename UniformSizes -> UniformSize
kushalkolar e07cbe8
update graphic methods mixin
kushalkolar f3a8f95
update graphic methods mixin
kushalkolar 06408a6
bugfix
kushalkolar a2f2e6f
test data slice for positiosn graphics
kushalkolar 71c06e0
test colors property within buffer tests
kushalkolar b5e9f2c
cleanup
kushalkolar d12bf4d
emit user key not parsed key
kushalkolar 3baaa95
rename cmap_values to transform
kushalkolar 255183b
cmap_values -> cmap_transform in mixin
kushalkolar 7392628
test graphics in vertex data buffer manager tests
kushalkolar 612adc5
cmap transform tests
kushalkolar 9a27cb7
make Graphic._features private, add Graphic.events property
kushalkolar fbfca0b
color events tests
kushalkolar 7c3520f
move data slice test to just buffer tests
kushalkolar c127fe7
data events tests
kushalkolar 18f7035
cleanup
kushalkolar 96065b7
cleanup, remove old histogram graphic
kushalkolar 444eed0
text changes and tests
kushalkolar 44d7286
texture array tests with graphic
kushalkolar 080d8ae
image graphic tests
kushalkolar 51db9dd
update image features
kushalkolar 1d3c111
black
kushalkolar 252b8bb
append data and world xy for graphic pointer events
kushalkolar 197a64f
black
kushalkolar b0d20f6
move constructor to top
kushalkolar 9f92ab7
example tests for wide and square hm
kushalkolar 613cc68
update ci
kushalkolar 12a0060
fix message
kushalkolar 49ffefd
update examples
kushalkolar 01e0371
bugfix, docstrings
kushalkolar 6ad1802
docstrings, exception messages
kushalkolar 44fc961
update api docs
kushalkolar 4f1f400
apparently we use __all__ in graphics to generate api docs
kushalkolar 82ec4b4
remove nbsphinx
kushalkolar 8f72fe5
bump version
kushalkolar 183440a
docstring
kushalkolar bb6d6b5
finish up line collection
clewis7 9df7574
fix adding line selector to line collection
clewis7 04eeb10
finish line collection
kushalkolar 72e54ee
update line collection examples
kushalkolar 3ce055e
graphic collections are now iterables, add examples for setting prope…
kushalkolar acd743c
3d line stack example with animation
kushalkolar ce078c6
fix line collection cmap with additional args
kushalkolar 4c69ab6
black
kushalkolar c2f647d
update kwargs for line collection because of mixin
kushalkolar 6d9cf62
add numpy.integer check for buffermanager parse slice
kushalkolar 7525209
rename
kushalkolar 0380ea9
docstrings
kushalkolar 43a9f8d
line linear selector init logic
kushalkolar cc2b92b
fix line collection init selectors
kushalkolar c8bf515
fix selector
kushalkolar 67dfd00
add plot area hook for collections
kushalkolar ea3cb02
docstring
kushalkolar f8518ee
update selector nbs
kushalkolar b379282
update example nb
kushalkolar 7eba849
update nb
kushalkolar 7280cf1
cleanup
kushalkolar 933a3e8
update nb
kushalkolar 3a53ac4
update nbs
kushalkolar a634907
feature is private class attr
kushalkolar a8d350a
fix
kushalkolar b6665f8
remove anim example from screenshot tests
kushalkolar 2e8e612
update screenshots
kushalkolar af6ab4f
update screenshot
kushalkolar 47cecfa
update CONTRIBUTING
kushalkolar 3079fa6
smaller hm data test for CI
kushalkolar d719ad6
exclude heatmap change data from tests, too large RAM usage probably
kushalkolar e63043c
black
kushalkolar 06a489f
change dtype to save ram usage for CI
kushalkolar b524799
remove large square heatmap from screenshot tests
kushalkolar fc5160e
black
kushalkolar 2c6d0ca
disable all but one hm test
kushalkolar 3fd7734
fix gc
kushalkolar 24b5d95
update screenshots
kushalkolar 25876bf
replace one more test image
kushalkolar eb83cfd
fix docs
kushalkolar 8696d32
update image screenshots
kushalkolar 70ca7c7
fix docs
kushalkolar 28e08b9
docstrings, Graphic.events -> Graphic.supported_events
kushalkolar d610690
update docs
kushalkolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
comment
- Loading branch information
commit 97b73038f0e6afc096cb4f807eb548f0aad1b6fa
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add doc string