Skip to content

Selection vector improve #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalkolar merged 12 commits into from
Aug 6, 2026
Merged

Selection vector improve #1061

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c6308e3
Full selection vector implementation
apasarkar Jun 11, 2026
393b48d
Includes some documentation at top of SelectionVector
apasarkar Jun 11, 2026
e80f963
Minor typing fix in linear selector selection setter
apasarkar Jun 11, 2026
174f861
First working version with selection vector
apasarkar Jun 12, 2026
3a4dfde
Reworks the logic for adding selectors, improves some documentation, …
apasarkar Jun 13, 2026
701250d
Fixes casting bug in the integer version of the code
apasarkar Jun 13, 2026
aa88e30
Update fastplotlib/graphics/selectors/_selection_vector.py
kushalkolar Aug 4, 2026
94242c7
Update fastplotlib/graphics/selectors/_selection_vector.py
kushalkolar Aug 4, 2026
878ea94
Merge branch 'ndwidget' into selection_vector_improve
kushalkolar Aug 4, 2026
cf1c380
Removes unused init time parameter and also updates the typing on the…
apasarkar Aug 5, 2026
d686a3e
Adds a nonneg check in selection vector selection setter
apasarkar Aug 6, 2026
8a397d8
Adds nonneg test for inverse handler
apasarkar Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removes unused init time parameter and also updates the typing on the… 
… default inverse mapping function to always return an integer
  • Loading branch information
@apasarkar
apasarkar committed Aug 5, 2026
commit cf1c3802490ab3d761d4beef8938c10ad42ccc67
4 changes: 2 additions & 2 deletions fastplotlib/graphics/selectors/_selection_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def array_map(arr: np.ndarray, index: Integral):
return None if np.isnan(arr[index]) else int(arr[index])

def inv_array_map(arr: np.ndarray,
value: int) -> None | Integral:
value: int) -> None | int:
"""
arr[i] gives the global index
"""
Expand All @@ -43,7 +43,7 @@ class SelectionVector:

The SelectionVector coordinates across individual selectors, including the coordinated updating of indices whenever a selection changes
"""
def __init__(self, max_size: int = None):
def __init__(self):
# selector -> (map, map_inv)

## Key is a selector, value is a (1) local to global index map (2) global to local index map (3) list of event handlers
Expand Down