Skip to content

use fully fledged async, NDPositions improvements #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalkolar merged 17 commits into from
May 29, 2026
Merged

use fully fledged async, NDPositions improvements #1050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c660721
use fully fledged async
kushalkolar May 9, 2026
c0affe5
better throttling
kushalkolar May 9, 2026
0490dcf
torch.Tensor.tranpose() doesn't like tuples
kushalkolar May 9, 2026
b65464c
Merge branch 'ndwidget-proper-async' of https://github.com/fastplotli…
kushalkolar May 9, 2026
2d79624
we need time-based throttling, but it can be gentler
kushalkolar May 10, 2026
8c5258f
improvements
kushalkolar May 10, 2026
5418044
Merge branch 'ndwidget' into ndwidget-proper-async
kushalkolar May 10, 2026
b7d585d
improvements
kushalkolar May 11, 2026
ebc500f
fixes
kushalkolar May 11, 2026
ff60d0f
x_range fix
kushalkolar May 11, 2026
2465a3a
fix NDPandasProcessor
kushalkolar May 11, 2026
d364425
fix
kushalkolar May 11, 2026
ab5cbea
HighlightSelector fix to append None
kushalkolar May 11, 2026
9cdebea
cleanup better
kushalkolar May 11, 2026
c522a70
know ndg current dipslayed indices
kushalkolar May 11, 2026
8256491
improve example
kushalkolar May 12, 2026
608798c
docstrings, cleanup
kushalkolar May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
@kushalkolar
kushalkolar committed May 11, 2026
commit ebc500f30d36947b891a2569ed8ff82ca5731eb8
8 changes: 4 additions & 4 deletions fastplotlib/widgets/nd_widget/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ def slider_dim_transforms(
"""get or set the slider_dim_transforms, see docstring for details"""
self.processor.slider_dim_transforms = maps
# force a render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

@property
def window_funcs(
Expand All @@ -736,7 +736,7 @@ def window_funcs(
):
self.processor.window_funcs = window_funcs
# force a render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

@property
def window_order(self) -> tuple[str, ...]:
Expand All @@ -747,7 +747,7 @@ def window_order(self) -> tuple[str, ...]:
def window_order(self, order: tuple[str] | None):
self.processor.window_order = order
# force a render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

@property
def spatial_func(self) -> Callable[[ArrayProtocol], ArrayProtocol] | None:
Expand All @@ -761,7 +761,7 @@ def spatial_func(
"""get or set the spatial_func, see docstring for details"""
self.processor.spatial_func = func
# force a render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

# def _repr_text_(self) -> str:
# return ndg_fmt_text(self)
Expand Down
4 changes: 2 additions & 2 deletions fastplotlib/widgets/nd_widget/_nd_positions/_nd_positions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ def spatial_dims(self) -> tuple[str, str, str]:
def spatial_dims(self, dims: tuple[str, str, str]):
self.processor.spatial_dims = dims
# force re-render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

@property
def indices(self) -> dict[Hashable, Any]:
Expand Down Expand Up @@ -1019,7 +1019,7 @@ def display_window(self, dw: int | float | None):
self.x_range_mode = None

# force re-render
run_sync(self._set_indices_(self.indices))
run_sync(self._set_indices_())

@property
def datapoints_window_func(self) -> tuple[Callable, str, int | float] | None:
Expand Down
2 changes: 1 addition & 1 deletion fastplotlib/widgets/nd_widget/_nd_positions/_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def tooltip_format(self, n: int, p: int):
p += self._dw_slice.start
return str(self.data[self._tooltip_columns[n]][p])

def get(self, indices: dict[str, Any]) -> dict[str, np.ndarray]:
async def get(self, indices: dict[str, Any]) -> dict[str, np.ndarray]:
# TODO: LOD by using a step size according to max_p
# TODO: Also what to do if display_window is None and data
# hasn't changed when indices keeps getting set, cache?
Expand Down