fix: correct isCustomSerializerCompiler flag check - #6657
Merged
mcollina merged 2 commits intoApr 20, 2026
Merged
Conversation
The isCustomSerializerCompiler flag was incorrectly checking opts.compilersFactory.buildValidator instead of opts.compilersFactory.buildSerializer, causing the flag to mirror isCustomValidatorCompiler rather than reflecting whether a custom serializer compiler was actually provided. Fixes: fastify#6652
climba03003
approved these changes
Apr 12, 2026
Eomm
reviewed
Apr 13, 2026
metcoder95
approved these changes
Apr 15, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6652. This replaces PR #6655 which was accidentally closed.
The
isCustomSerializerCompilerflag inlib/schema-controller.jswas incorrectly checkingopts?.compilersFactory?.buildValidatorinstead ofopts?.compilersFactory?.buildSerializer. This caused the flag to always mirrorisCustomValidatorCompilerrather than independently tracking whether a custom serializer compiler was provided.Changes
lib/schema-controller.js: Changed theisCustomSerializerCompilerinitialization to checkbuildSerializerinstead ofbuildValidatortest/internals/schema-controller-perf.test.js: Added two test cases verifying thatisCustomSerializerCompilerandisCustomValidatorCompilerare set independently based on which compiler factory functions are provided