Skip to content

fix(pkg/da): fallback to polling when ws cannot connect #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
Mar 30, 2026
Merged

fix(pkg/da): fallback to polling when ws cannot connect #3211

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84e0fd0
fix(pkg/da): fallback to polling when ws cannot connect
julienrbrt Mar 30, 2026
53ec7cb
log err and fix typos
julienrbrt Mar 30, 2026
102f297
rewording
julienrbrt Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rewording
  • Loading branch information
@julienrbrt
julienrbrt committed Mar 30, 2026
commit 102f2975d1d92979b6cb142340f8a6f058371c43
2 changes: 1 addition & 1 deletion pkg/da/jsonrpc/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func NewClient(ctx context.Context, addr, token string, authHeaderName string) (
// Automatically converts http:// to ws:// (and https:// to wss://).
// Supports channel-based subscriptions (e.g. Subscribe).
// Note: WebSocket connections are eager — they connect at creation time
// if it fails, we fallback to non websocket connection for the whole runtime process.
// if the initial WS dial fails, falls back to HTTP polling for the entire session.
func NewWSClient(ctx context.Context, logger zerolog.Logger, addr, token string, authHeaderName string) (*Client, error) {
client, err := NewClient(ctx, httpToWS(addr), token, authHeaderName)
if err != nil {
Expand Down
Loading