Skip to content

chore: add stricter linting #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 9 commits into from
Mar 4, 2026
Merged

chore: add stricter linting #3132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4dc50b
add stricterlinting
tac0turtle Mar 3, 2026
d4063fe
revert some changes and enable prealloc and predeclared
tac0turtle Mar 3, 2026
4400594
ci
tac0turtle Mar 3, 2026
36f7a47
Merge branch 'main' into marko/linting
tac0turtle Mar 3, 2026
ed63711
fix lint
tac0turtle Mar 3, 2026
b4bd5ea
fix comments
tac0turtle Mar 4, 2026
fb25598
fix
tac0turtle Mar 4, 2026
917e3c9
remove spec
tac0turtle Mar 4, 2026
bc3584e
test stability
tac0turtle Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comments
  • Loading branch information
@tac0turtle
tac0turtle committed Mar 4, 2026
commit b4bd5ea5e74ec8bb9c21b978b01d51d658c86bad
6 changes: 0 additions & 6 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,32 +12,26 @@ linters:
- asciicheck
- bidichk
- bodyclose
- containedctx
- contextcheck
- copyloopvar
- durationcheck
- errname
- errcheck
- errorlint
- gocritic
- govet
- ineffassign
- makezero
- gosec
- misspell
- nilerr
- noctx
- nolintlint
- prealloc
- predeclared
- reassign
- revive
- rowserrcheck
- sqlclosecheck
- staticcheck
- testifylint
- unconvert
- unparam
- unused
- usestdlibvars
- wastedassign
Comment thread
tac0turtle marked this conversation as resolved.
Expand Down
6 changes: 3 additions & 3 deletions block/internal/syncing/syncer_backoff_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func TestSyncer_BackoffOnDAError(t *testing.T) {
}

// Run sync loop
syncer.startSyncWorkers(t.Context())
syncer.startSyncWorkers(ctx)
<-ctx.Done()
syncer.wg.Wait()

Expand Down Expand Up @@ -223,7 +223,7 @@ func TestSyncer_BackoffResetOnSuccess(t *testing.T) {
go syncer.processLoop()

// Run workers
syncer.startSyncWorkers(t.Context())
syncer.startSyncWorkers(ctx)
<-ctx.Done()
syncer.wg.Wait()

Expand Down Expand Up @@ -294,7 +294,7 @@ func TestSyncer_BackoffBehaviorIntegration(t *testing.T) {
Return(nil, datypes.ErrBlobNotFound).Once()

go syncer.processLoop()
syncer.startSyncWorkers(t.Context())
syncer.startSyncWorkers(ctx)
<-ctx.Done()
syncer.wg.Wait()

Expand Down
Loading