limit abstractions

julienrbrt · Nov 26, 2025 · Nov 27, 2025 · Nov 28, 2025 · Nov 28, 2025 · Nov 28, 2025
commit 3a2ba3fe7a842bd097812785343666573255609e
diff --git a/.mockery.yaml b/.mockery.yaml
@@ -61,11 +61,7 @@ packages:
           dir: ./block/internal/syncing
           pkgname: syncing
           filename: syncer_mock.go
-      HeightStore:
-        config:
-          dir: ./block/internal/syncing
-          pkgname: syncing
-          filename: height_store_mock.go
+
   github.com/evstack/ev-node/block/internal/common:
     interfaces:
       Broadcaster:

diff --git a/block/components.go b/block/components.go
@@ -127,8 +127,8 @@ func NewSyncComponents(
 	store store.Store,
 	exec coreexecutor.Executor,
 	daClient da.Client,
-	headerStore *sync.HeaderSyncService,
-	dataStore *sync.DataSyncService,
+	headerSyncService *sync.HeaderSyncService,
+	dataSyncService *sync.DataSyncService,
 	logger zerolog.Logger,
 	metrics *Metrics,
 	blockOpts BlockOptions,
@@ -150,8 +150,8 @@ func NewSyncComponents(
 		metrics,
 		config,
 		genesis,
-		headerStore,
-		dataStore,
+		headerSyncService.Store(),
+		dataSyncService.Store(),
 		logger,
 		blockOpts,
 		errorCh,
@@ -163,7 +163,7 @@ func NewSyncComponents(
 	}
 
 	// Create submitter for sync nodes (no signer, only DA inclusion processing)
-	var daSubmitter submitting.DASubmitterAPI = submitting.NewDASubmitter(daClient, config, genesis, blockOpts, metrics, logger, headerStore, dataStore)
+	var daSubmitter submitting.DASubmitterAPI = submitting.NewDASubmitter(daClient, config, genesis, blockOpts, metrics, logger, headerSyncService, dataSyncService)
 	if config.Instrumentation.IsTracingEnabled() {
 		daSubmitter = submitting.WithTracingDASubmitter(daSubmitter)
 	}
@@ -200,8 +200,8 @@ func NewAggregatorComponents(
 	sequencer coresequencer.Sequencer,
 	daClient da.Client,
 	signer signer.Signer,
-	headerBroadcaster *sync.HeaderSyncService,
-	dataBroadcaster *sync.DataSyncService,
+	headerSyncService *sync.HeaderSyncService,
+	dataSyncService *sync.DataSyncService,
 	logger zerolog.Logger,
 	metrics *Metrics,
 	blockOpts BlockOptions,
@@ -229,8 +229,8 @@ func NewAggregatorComponents(
 		metrics,
 		config,
 		genesis,
-		headerBroadcaster,
-		dataBroadcaster,
+		headerSyncService,
+		dataSyncService,
 		logger,
 		blockOpts,
 		errorCh,
@@ -266,7 +266,7 @@ func NewAggregatorComponents(
 		}, nil
 	}
 
-	var daSubmitter submitting.DASubmitterAPI = submitting.NewDASubmitter(daClient, config, genesis, blockOpts, metrics, logger, headerBroadcaster, dataBroadcaster)
+	var daSubmitter submitting.DASubmitterAPI = submitting.NewDASubmitter(daClient, config, genesis, blockOpts, metrics, logger, headerSyncService, dataSyncService)
 	if config.Instrumentation.IsTracingEnabled() {
 		daSubmitter = submitting.WithTracingDASubmitter(daSubmitter)
 	}

diff --git a/block/internal/common/broadcaster_mock.go b/block/internal/common/broadcaster_mock.go
diff --git a/block/internal/common/expected_interfaces.go b/block/internal/common/expected_interfaces.go
@@ -17,8 +17,6 @@ type (
 // Broadcaster interface for P2P broadcasting
 type Broadcaster[H header.Header[H]] interface {
 	WriteToStoreAndBroadcast(ctx context.Context, payload H, opts ...pubsub.PubOpt) error
-	AppendDAHint(ctx context.Context, daHeight uint64, hashes ...types.Hash) error
-	GetByHeight(ctx context.Context, height uint64) (H, uint64, error)
 	Store() header.Store[H]
 	Height() uint64
 }
diff --git a/block/internal/executing/executor.go b/block/internal/executing/executor.go
@@ -549,10 +549,10 @@ func (e *Executor) ProduceBlock(ctx context.Context) error {
 	// broadcast header and data to P2P network
 	g, broadcastCtx := errgroup.WithContext(e.ctx)
 	g.Go(func() error {
-		return e.headerBroadcaster.WriteToStoreAndBroadcast(broadcastCtx, &types.P2PSignedHeader{Message: header})
+		return e.headerBroadcaster.WriteToStoreAndBroadcast(broadcastCtx, &types.P2PSignedHeader{SignedHeader: header})
 	})
 	g.Go(func() error {
-		return e.dataBroadcaster.WriteToStoreAndBroadcast(broadcastCtx, &types.P2PData{Message: data})
+		return e.dataBroadcaster.WriteToStoreAndBroadcast(broadcastCtx, &types.P2PData{Data: data})
 	})
 	if err := g.Wait(); err != nil {
 		e.logger.Error().Err(err).Msg("failed to broadcast header and/data")

diff --git a/block/internal/syncing/height_store_mock.go b/block/internal/syncing/height_store_mock.go