fix: add ErrHeightFromFuture check to local-da GetAll

The LocalDA's GetAll method was missing the height-from-future check that existed in the old GetIDs method. This caused the syncer to iterate indefinitely instead of backing off when caught up with DA. Also simplified IsHeightDAIncluded by removing unused variable.
randygrok · Nov 27, 2025 · Nov 28, 2025 · Nov 28, 2025 · Nov 28, 2025 · Nov 28, 2025
commit 4ad19eeaf2378029312d3c1a970261c89eed1ff9
diff --git a/block/internal/submitting/submitter.go b/block/internal/submitting/submitter.go
@@ -390,10 +390,9 @@ func (s *Submitter) IsHeightDAIncluded(height uint64, header *types.SignedHeader
 
 	headerHash := header.Hash().String()
 	dataCommitment := data.DACommitment()
-	dataHash := dataCommitment.String()
 
 	_, headerIncluded := s.cache.GetHeaderDAIncluded(headerHash)
-	_, dataIncluded := s.cache.GetDataDAIncluded(dataHash)
+	_, dataIncluded := s.cache.GetDataDAIncluded(dataCommitment.String())
 
 	dataIncluded = bytes.Equal(dataCommitment, common.DataHashForEmptyTxs) || dataIncluded
 

diff --git a/da/cmd/local-da/local.go b/da/cmd/local-da/local.go
@@ -73,6 +73,11 @@ func (d *LocalDA) GetAll(ctx context.Context, height uint64, namespaces []share.
 	d.mu.RLock()
 	defer d.mu.RUnlock()
 
+	// Return error if requesting a height from the future
+	if height > d.height {
+		return nil, fmt.Errorf("height %d is in the future (current: %d): given height is from the future", height, d.height)
+	}
+
 	entries, ok := d.blobs[height]
 	if !ok {
 		return nil, nil