Skip to content

refactor!: create da client and split cache interface #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 5 commits into from
Nov 21, 2025
Merged

refactor!: create da client and split cache interface #2878

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3090e41
refactor: create da client and split cache interface
julienrbrt Nov 21, 2025
f3a3098
improvements
julienrbrt Nov 21, 2025
a36b417
nit
julienrbrt Nov 21, 2025
ac6430c
add go doc
julienrbrt Nov 21, 2025
5336661
go mod tidy
julienrbrt Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improvements
  • Loading branch information
@julienrbrt
julienrbrt committed Nov 21, 2025
commit f3a3098e00eb8464bbef3b6cb697599363ce25d6
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Rename `evm-single` to `evm` and `grpc-single` to `evgrpc` for clarity. [#2839](https://github.com/evstack/ev-node/pull/2839)
- Split cache interface in `CacheManager` and `PendingManager` and create `da` client to easy DA handling.
- Split cache interface in `CacheManager` and `PendingManager` and create `da` client to easy DA handling. [#2878](https://github.com/evstack/ev-node/pull/2878)

## v1.0.0-beta.10

Expand Down
2 changes: 1 addition & 1 deletion block/internal/syncing/p2p_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func NewP2PHandler(

// SetProcessedHeight updates the highest processed block height.
func (h *P2PHandler) SetProcessedHeight(height uint64) {
for {
for range 1_000 {

@julienrbrt julienrbrt Nov 21, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://github.com/evstack/ev-node/pull/2868/files#diff-b4e2c94aa607c5394b5031021292365f74597ac046d65186e15980b6a3e2f9dcR105 / #2873 (comment) to keep consistency

current := h.processedHeight.Load()
if height <= current {
return
Expand Down
9 changes: 5 additions & 4 deletions block/internal/syncing/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,11 @@ func (s *Syncer) Start(ctx context.Context) error {
}

// Start main processing loop
go s.processLoop()
s.wg.Add(1)

@julienrbrt julienrbrt Nov 21, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted as per #2873 (comment)

go func() {
defer s.wg.Done()
s.processLoop()
}()

// Start dedicated workers for DA, and pending processing
s.startSyncWorkers()
Expand Down Expand Up @@ -220,9 +224,6 @@ func (s *Syncer) initializeState() error {

// processLoop is the main coordination loop for processing events
func (s *Syncer) processLoop() {
s.wg.Add(1)
defer s.wg.Done()

s.logger.Info().Msg("starting process loop")
defer s.logger.Info().Msg("process loop stopped")

Expand Down
Loading