reduce diff

tac0turtle · Oct 13, 2025 · Oct 6, 2025 · Oct 6, 2025 · Oct 6, 2025 · Oct 6, 2025
commit 0eb1c766a2d5444ce5bb0682d895863cca96bc27
diff --git a/block/components.go b/block/components.go
@@ -5,7 +5,7 @@ import (
 	"errors"
 	"fmt"
 
-	"github.com/celestiaorg/go-header"
+	goheader "github.com/celestiaorg/go-header"
 	"github.com/rs/zerolog"
 
 	"github.com/evstack/ev-node/block/internal/cache"
@@ -122,6 +122,11 @@ func (bc *Components) Stop() error {
 	return errs
 }
 
+// broadcaster interface for P2P broadcasting
+type broadcaster[T any] interface {
+	WriteToStoreAndBroadcast(ctx context.Context, payload T) error
+}
+
 // NewSyncComponents creates components for a non-aggregator full node that can only sync blocks.
 // Non-aggregator full nodes can sync from P2P and DA but cannot produce blocks or submit to DA.
 // They have more sync capabilities than light nodes but no block production. No signer required.
@@ -131,8 +136,8 @@ func NewSyncComponents(
 	store store.Store,
 	exec coreexecutor.Executor,
 	da coreda.DA,
-	headerStore header.Store[*types.SignedHeader],
-	dataStore header.Store[*types.Data],
+	headerStore goheader.Store[*types.SignedHeader],
+	dataStore goheader.Store[*types.Data],
 	logger zerolog.Logger,
 	metrics *Metrics,
 	blockOpts BlockOptions,
@@ -183,11 +188,6 @@ func NewSyncComponents(
 	}, nil
 }
 
-// broadcaster interface for P2P broadcasting
-type broadcaster[T any] interface {
-	WriteToStoreAndBroadcast(ctx context.Context, payload T) error
-}
-
 // NewAggregatorComponents creates components for an aggregator full node that can produce and sync blocks.
 // Aggregator nodes have full capabilities - they can produce blocks, sync from P2P and DA,
 // and submit headers/data to DA. Requires a signer for block production and DA submission.

diff --git a/block/internal/executing/executor.go b/block/internal/executing/executor.go
@@ -41,7 +41,7 @@ type Executor struct {
 	cache   cache.Manager
 	metrics *common.Metrics
 
-	// P2P handling
+	// Broadcasting
 	headerBroadcaster broadcaster[*types.SignedHeader]
 	dataBroadcaster   broadcaster[*types.Data]
 

diff --git a/block/internal/executing/executor_test.go b/block/internal/executing/executor_test.go
@@ -5,7 +5,6 @@ import (
 	"testing"
 	"time"
 
-	goheader "github.com/celestiaorg/go-header"
 	"github.com/ipfs/go-datastore"
 	"github.com/ipfs/go-datastore/sync"
 	"github.com/rs/zerolog"
@@ -21,7 +20,7 @@ import (
 )
 
 // mockBroadcaster for testing
-type mockBroadcaster[T goheader.Header[T]] struct {
+type mockBroadcaster[T any] struct {
 	called  bool
 	payload T
 }
@@ -32,10 +31,6 @@ func (m *mockBroadcaster[T]) WriteToStoreAndBroadcast(ctx context.Context, paylo
 	return nil
 }
 
-func (m *mockBroadcaster[T]) Store() goheader.Store[T] {
-	panic("should not be needed")
-}
-
 func TestExecutor_BroadcasterIntegration(t *testing.T) {
 	// Create in-memory store
 	ds := sync.MutexWrap(datastore.NewMapDatastore())