Skip to content

refactor(block): save header to context #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 6 commits into from
Jun 9, 2025
Merged

refactor(block): save header to context #2346

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab78ae2
refactor(block): save header to context
julienrbrt Jun 6, 2025
d8498c1
comment
julienrbrt Jun 6, 2025
5e7975e
Merge branch 'main' into julien/header-in-ctx
julienrbrt Jun 9, 2025
ad62107
update initial version
julienrbrt Jun 9, 2025
37f5859
bring back signature verifier (as optional)
julienrbrt Jun 9, 2025
91741bf
fix test
julienrbrt Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@julienrbrt
julienrbrt committed Jun 9, 2025
commit 91741bfc662a0994886cbeec4fdf041148bd90d2
4 changes: 2 additions & 2 deletions block/publish_block_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func Test_publishBlock_EmptyBatch(t *testing.T) {

// We should also expect ExecuteTxs to be called with an empty transaction list
newAppHash := []byte("newAppHash")
mockExec.On("ExecuteTxs", ctx, mock.Anything, currentHeight+1, mock.AnythingOfType("time.Time"), m.lastState.AppHash).Return(newAppHash, uint64(100), nil).Once()
mockExec.On("ExecuteTxs", mock.Anything, mock.Anything, currentHeight+1, mock.AnythingOfType("time.Time"), m.lastState.AppHash).Return(newAppHash, uint64(100), nil).Once()

// SetHeight should be called
mockStore.On("SetHeight", ctx, currentHeight+1).Return(nil).Once()
Expand Down Expand Up @@ -380,7 +380,7 @@ func Test_publishBlock_Success(t *testing.T) {
sampleTxs := [][]byte{[]byte("tx1"), []byte("tx2")}
// No longer mocking GetTxs since it's handled by reaper.go
newAppHash := []byte("newAppHash")
mockExec.On("ExecuteTxs", t.Context(), mock.Anything, newHeight, mock.AnythingOfType("time.Time"), manager.lastState.AppHash).Return(newAppHash, uint64(100), nil).Once()
mockExec.On("ExecuteTxs", mock.Anything, mock.Anything, newHeight, mock.AnythingOfType("time.Time"), manager.lastState.AppHash).Return(newAppHash, uint64(100), nil).Once()

// No longer mocking SubmitBatchTxs since it's handled by reaper.go
batchTimestamp := lastHeader.Time().Add(1 * time.Second)
Expand Down