Repository navigation
feat: Add DA Includer #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: Add DA Includer #2245
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
86ed975
create lazy aggregation adr proposal
ed5dce1
ammend based on feedback
ee3550d
Merge branch 'main' into marko/lazy-aggregation-adr
e7472d7
Update specs/lazy-adr/adr-021-lazy-aggregation.md
tac0turtle 10ea3ae
Merge branch 'main' into marko/lazy-aggregation-adr
tac0turtle cb5fb90
lint fix
f68588b
Merge branch 'main' into marko/lazy-aggregation-adr
tac0turtle 7fb554a
chore: empty blocks & lazy aggrgation (#2243)
tac0turtle 4219dd2
remove unused
4949f09
reset block timer when no txs are present
95897a4
Simplify
Manav-Aggarwal 0ea7657
Fix test
Manav-Aggarwal 4d4d9d2
Add reaper logic in adr
Manav-Aggarwal b19a14e
Implement execValidate and insert back dataHash
Manav-Aggarwal d938c88
Add batchValidation in retriever
Manav-Aggarwal 71dec18
modify validation logic
Manav-Aggarwal 5a74dc4
Add DA Includer Loop
Manav-Aggarwal 446cd75
Fix test syntax
Manav-Aggarwal eccf399
Add Validate method for signed header
Manav-Aggarwal 05d2888
setDAIncluded for sequencers too
Manav-Aggarwal 609d51d
Fix first retriever test
Manav-Aggarwal 6cb6b1b
Refactor retriever and fix more tests
Manav-Aggarwal f616f69
fixed all retriever tests
Manav-Aggarwal 6648f6c
Add more tests to retriever and handle empty blobs
Manav-Aggarwal 91c30a8
make fromProto more robust
Manav-Aggarwal 4dc7f9b
Add doc headers to add test methods in block package
Manav-Aggarwal 1bf36e6
Make TestProcessNextDAHeader_MultipleHeadersAndBatches more robust
Manav-Aggarwal fe160ce
Fix from rebase
Manav-Aggarwal 8c3006a
fix publishBlock tests
Manav-Aggarwal a16e63b
Add daIncluderTests
Manav-Aggarwal 66cc82d
enable t.Parallel in all block tests
Manav-Aggarwal 66a34c8
go mod tidy everywhere
Manav-Aggarwal 76f652b
catch errcheck in setfinal and add test for it in daIncluder
Manav-Aggarwal 3925c86
fix lint
Manav-Aggarwal b1c076e
remove gci from golintci
Manav-Aggarwal c0f82b3
Fix first test in sync_test
Manav-Aggarwal 58ce301
Fix all sync tests
Manav-Aggarwal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix test
- Loading branch information
commit 0ea76571d7d7e3b83549f29acaa96fcc4cf2d6b1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic string key likely a typo
SetMetadatais invoked with the literal"l":Everywhere else the constant
LastBatchDataKeyis used.Using the wrong key means the test no longer checks the production path and may mask regressions.