remove channel from sequencer constructor

julienrbrt · May 15, 2025 · Apr 30, 2025 · May 2, 2025 · May 2, 2025 · May 2, 2025
commit 21c72315c07c2f3e4f31c578bfd2eb69b3642ac9
diff --git a/sequencers/single/sequencer.go b/sequencers/single/sequencer.go
@@ -53,17 +53,15 @@ func NewSequencer(
 	batchTime time.Duration,
 	metrics *Metrics,
 	proposer bool,
-	batchSubmissionChan chan coresequencer.Batch,
 ) (*Sequencer, error) {
 	s := &Sequencer{
-		logger:              logger,
-		da:                  da,
-		batchTime:           batchTime,
-		rollupId:            rollupId,
-		queue:               NewBatchQueue(db, "batches"),
-		batchSubmissionChan: batchSubmissionChan,
-		metrics:             metrics,
-		proposer:            proposer,
+		logger:    logger,
+		da:        da,
+		batchTime: batchTime,
+		rollupId:  rollupId,
+		queue:     NewBatchQueue(db, "batches"),
+		metrics:   metrics,
+		proposer:  proposer,
 	}
 
 	loadCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)

diff --git a/sequencers/single/sequencer_test.go b/sequencers/single/sequencer_test.go
@@ -26,7 +26,8 @@ func TestNewSequencer(t *testing.T) {
 	db := ds.NewMapDatastore()
 	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
 	defer cancel()
-	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, []byte("rollup1"), 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
+	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, []byte("rollup1"), 10*time.Second, metrics, false)
+	seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
 	if err != nil {
 		t.Fatalf("Failed to create sequencer: %v", err)
 	}
@@ -58,7 +59,8 @@ func TestSequencer_SubmitRollupBatchTxs(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
 	defer cancel()
 	rollupId := []byte("rollup1")
-	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
+	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false)
+	seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
 	if err != nil {
 		t.Fatalf("Failed to create sequencer: %v", err)
 	}
@@ -110,7 +112,8 @@ func TestSequencer_SubmitRollupBatchTxs_EmptyBatch(t *testing.T) {
 	ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
 	defer cancel()
 	rollupId := []byte("rollup1")
-	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
+	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false)
+	seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
 	require.NoError(t, err, "Failed to create sequencer")
 	defer func() {
 		err := db.Close()
@@ -382,7 +385,8 @@ func TestSequencer_GetNextBatch_BeforeDASubmission(t *testing.T) {
 	db := ds.NewMapDatastore()
 	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 	defer cancel()
-	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, mockDA, []byte("rollup1"), 1*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
+	seq, err := NewSequencer(ctx, log.NewNopLogger(), db, mockDA, []byte("rollup1"), 1*time.Second, metrics, false)
+	seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
 	if err != nil {
 		t.Fatalf("Failed to create sequencer: %v", err)
 	}